From 567a9508cb358f330ebbfbfe99a18c5238874bd1 Mon Sep 17 00:00:00 2001 From: David <33458145+davidmcpowell@users.noreply.github.com> Date: Tue, 15 Jul 2025 09:58:30 +0100 Subject: [PATCH] Merge pull request #27128 from overleaf/mj-ide-tooltip-teardown [web] Editor Redesign: Tear down editor nudge tooltips GitOrigin-RevId: 83c412ad782d041c960eba8533ffc49935524b9c --- .../src/Features/Project/ProjectController.js | 2 -- .../web/frontend/extracted-translations.json | 4 ---- .../try-new-editor-button.tsx | 20 +------------------ .../components/toolbar/labs-actions.tsx | 17 +--------------- services/web/locales/en.json | 4 ---- 5 files changed, 2 insertions(+), 45 deletions(-) diff --git a/services/web/app/src/Features/Project/ProjectController.js b/services/web/app/src/Features/Project/ProjectController.js index 6cd297d213..3570834e04 100644 --- a/services/web/app/src/Features/Project/ProjectController.js +++ b/services/web/app/src/Features/Project/ProjectController.js @@ -351,8 +351,6 @@ const _ProjectController = { 'word-count-client', 'editor-popup-ux-survey', 'new-editor-error-logs-redesign', - 'ide-redesign-experiment-nudge', - 'ide-redesign-new-survey-prompt', ].filter(Boolean) const getUserValues = async userId => diff --git a/services/web/frontend/extracted-translations.json b/services/web/frontend/extracted-translations.json index 345bbb7a0e..b0e70cafe3 100644 --- a/services/web/frontend/extracted-translations.json +++ b/services/web/frontend/extracted-translations.json @@ -442,7 +442,6 @@ "doing_this_will_verify_affiliation_and_allow_log_in_2": "", "done": "", "dont_forget_you_currently_have": "", - "dont_miss_out_on_the_updated_editor": "", "dont_reload_or_close_this_tab": "", "double_clicking_on_the_pdf_shows": "", "download": "", @@ -780,7 +779,6 @@ "hotkey_toggle_track_changes": "", "hotkey_undo": "", "hotkeys": "", - "how_are_you_finding_the_updates_to_the_new_editor": "", "how_it_works": "", "how_many_licenses_do_you_want_to_buy": "", "how_to_create_tables": "", @@ -1737,7 +1735,6 @@ "take_short_survey": "", "take_survey": "", "tell_the_project_owner_and_ask_them_to_upgrade": "", - "tell_us_what_you_think": "", "template": "", "template_description": "", "template_title_taken_from_project_title": "", @@ -2081,7 +2078,6 @@ "were_performing_maintenance": "", "were_redesigning_our_editor_to_make_it_easier_to_use": "", "were_reducing_compile_timeout": "", - "weve_been_making_changes_and_improvements_why_not_give_it_a_try": "", "what_did_you_find_most_helpful": "", "what_do_you_need_help_with": "", "what_does_this_mean": "", diff --git a/services/web/frontend/js/features/editor-navigation-toolbar/try-new-editor-button.tsx b/services/web/frontend/js/features/editor-navigation-toolbar/try-new-editor-button.tsx index 775c985a1f..c9b85025de 100644 --- a/services/web/frontend/js/features/editor-navigation-toolbar/try-new-editor-button.tsx +++ b/services/web/frontend/js/features/editor-navigation-toolbar/try-new-editor-button.tsx @@ -1,19 +1,13 @@ -import { useCallback, useRef } from 'react' +import { useCallback } from 'react' import OLButton from '../ui/components/ol/ol-button' import { useIdeRedesignSwitcherContext } from '../ide-react/context/ide-redesign-switcher-context' import MaterialIcon from '@/shared/components/material-icon' import { useTranslation } from 'react-i18next' -import TooltipPromotion from '../ide-redesign/components/tooltip-promo' - -const TUTORIAL_KEY = 'try-redesign-again-nudge-promo' -const EVENT_DATA = { name: 'try-redesign-again-nudge-promotion' } const TryNewEditorButton = () => { const { t } = useTranslation() const { setShowSwitcherModal } = useIdeRedesignSwitcherContext() - const switcherButtonRef = useRef(null) - const onClick = useCallback(() => { setShowSwitcherModal(true) }, [setShowSwitcherModal]) @@ -25,21 +19,9 @@ const TryNewEditorButton = () => { size="sm" leadingIcon={} variant="secondary" - ref={switcherButtonRef} > {t('try_the_new_editor')} - ) } diff --git a/services/web/frontend/js/features/ide-redesign/components/toolbar/labs-actions.tsx b/services/web/frontend/js/features/ide-redesign/components/toolbar/labs-actions.tsx index 56b4323b61..69c38d3b6a 100644 --- a/services/web/frontend/js/features/ide-redesign/components/toolbar/labs-actions.tsx +++ b/services/web/frontend/js/features/ide-redesign/components/toolbar/labs-actions.tsx @@ -2,13 +2,9 @@ import { useIdeRedesignSwitcherContext } from '@/features/ide-react/context/ide- import OLButton from '@/features/ui/components/ol/ol-button' import OLTooltip from '@/features/ui/components/ol/ol-tooltip' import MaterialIcon from '@/shared/components/material-icon' -import { useCallback, useRef } from 'react' +import { useCallback } from 'react' import { useTranslation } from 'react-i18next' import { useSurveyUrl } from '../../hooks/use-survey-url' -import TooltipPromotion from '../tooltip-promo' - -const TUTORIAL_KEY = 'ide-redesign-new-survey-promo' -const EVENT_DATA = { name: 'ide-redesign-new-survey-promotion' } export const LabsActions = () => { const { t } = useTranslation() @@ -17,7 +13,6 @@ export const LabsActions = () => { setShowSwitcherModal(true) }, [setShowSwitcherModal]) const surveyURL = useSurveyUrl() - const feedbackLinkRef = useRef(null) return ( <> @@ -42,7 +37,6 @@ export const LabsActions = () => {
{ > {t('give_feedback')} -
) diff --git a/services/web/locales/en.json b/services/web/locales/en.json index 23cc4e251a..e67a350dac 100644 --- a/services/web/locales/en.json +++ b/services/web/locales/en.json @@ -575,7 +575,6 @@ "done": "Done", "dont_forget_you_currently_have": "Don’t forget, you currently have:", "dont_have_account": "Don’t have an account?", - "dont_miss_out_on_the_updated_editor": "Don’t miss out on the updated editor", "dont_reload_or_close_this_tab": "Don’t reload or close this tab.", "double_clicking_on_the_pdf_shows": "Double clicking on the PDF shows the corresponding location in code. Added word count (7 May 2025)", "download": "Download", @@ -1000,7 +999,6 @@ "hotkey_toggle_track_changes": "Toggle track changes", "hotkey_undo": "Undo", "hotkeys": "Hotkeys", - "how_are_you_finding_the_updates_to_the_new_editor": "How are you finding the updates to the new editor?", "how_it_works": "How it works", "how_many_licenses_do_you_want_to_buy": "How many licenses do you want to buy?", "how_many_users_do_you_need": "How many users do you need?", @@ -2237,7 +2235,6 @@ "take_short_survey": "Take a short survey", "take_survey": "Take survey", "tell_the_project_owner_and_ask_them_to_upgrade": "<0>Tell the project owner and ask them to upgrade their Overleaf plan if you need more compile time.", - "tell_us_what_you_think": "Tell us what you think", "template": "Template", "template_approved_by_publisher": "This template has been approved by the publisher", "template_description": "Template Description", @@ -2628,7 +2625,6 @@ "were_performing_maintenance": "We’re performing maintenance on Overleaf and you need to wait a moment. Sorry for any inconvenience. The editor will refresh automatically in __seconds__ seconds.", "were_redesigning_our_editor_to_make_it_easier_to_use": "We’re redesigning our editor to make it easier to use and ensure it’s future ready. Try it out and give us your feedback to help us get this right. (Some features are still in the works, so you can switch back at any time.)", "were_reducing_compile_timeout": "We’re in the process of <0>reducing the compile timeout limit on our free plan, which may affect your project in future.", - "weve_been_making_changes_and_improvements_why_not_give_it_a_try": "We’ve been making changes and improvements. Why not give it a try?", "what_did_you_find_most_helpful": "What did you find most helpful?", "what_do_you_need": "What do you need?", "what_do_you_need_help_with": "What do you need help with?",