From 4d4dba96777e2c103e9c2e4d316991f8ec783e24 Mon Sep 17 00:00:00 2001 From: Alasdair Smith Date: Thu, 19 Oct 2017 15:31:19 +0100 Subject: [PATCH 1/3] Adds some onboarding logging to investigate potential bug --- .../web/app/coffee/Features/Project/ProjectController.coffee | 1 + 1 file changed, 1 insertion(+) diff --git a/services/web/app/coffee/Features/Project/ProjectController.coffee b/services/web/app/coffee/Features/Project/ProjectController.coffee index 80c74754e0..4cebc197a7 100644 --- a/services/web/app/coffee/Features/Project/ProjectController.coffee +++ b/services/web/app/coffee/Features/Project/ProjectController.coffee @@ -273,6 +273,7 @@ module.exports = ProjectController = else if event? return cb(null, false) else + logger.log user_id, event, "autocompile onboarding not shown yet to this user" return cb(null, true) }, (err, results)-> if err? From 6fd1d493e3ddf28801c0ba415036760d914fe918 Mon Sep 17 00:00:00 2001 From: Alasdair Smith Date: Thu, 19 Oct 2017 15:47:12 +0100 Subject: [PATCH 2/3] Also add logging for track changes --- .../web/app/coffee/Features/Project/ProjectController.coffee | 2 ++ 1 file changed, 2 insertions(+) diff --git a/services/web/app/coffee/Features/Project/ProjectController.coffee b/services/web/app/coffee/Features/Project/ProjectController.coffee index 4cebc197a7..6e3b84f383 100644 --- a/services/web/app/coffee/Features/Project/ProjectController.coffee +++ b/services/web/app/coffee/Features/Project/ProjectController.coffee @@ -229,6 +229,7 @@ module.exports = ProjectController = else if event? return cb(null, false) else + logger.log user_id, event, "track changes onboarding not shown yet to this user" return cb(null, true) showPerUserTCNotice: (cb) -> cb = underscore.once(cb) @@ -247,6 +248,7 @@ module.exports = ProjectController = else if event? return cb(null, false) else + logger.log user_id, event, "per user track changes notice not shown yet to this user" return cb(null, true) showAutoCompileOnboarding: (cb) -> cb = underscore.once(cb) From ebaa640c516dd2b6646c3c209339c91d7c72ed51 Mon Sep 17 00:00:00 2001 From: Alasdair Smith Date: Thu, 19 Oct 2017 16:02:40 +0100 Subject: [PATCH 3/3] Fix log call signature --- .../app/coffee/Features/Project/ProjectController.coffee | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/services/web/app/coffee/Features/Project/ProjectController.coffee b/services/web/app/coffee/Features/Project/ProjectController.coffee index 6e3b84f383..424fe7e248 100644 --- a/services/web/app/coffee/Features/Project/ProjectController.coffee +++ b/services/web/app/coffee/Features/Project/ProjectController.coffee @@ -229,7 +229,7 @@ module.exports = ProjectController = else if event? return cb(null, false) else - logger.log user_id, event, "track changes onboarding not shown yet to this user" + logger.log { user_id, event }, "track changes onboarding not shown yet to this user" return cb(null, true) showPerUserTCNotice: (cb) -> cb = underscore.once(cb) @@ -248,7 +248,7 @@ module.exports = ProjectController = else if event? return cb(null, false) else - logger.log user_id, event, "per user track changes notice not shown yet to this user" + logger.log { user_id, event }, "per user track changes notice not shown yet to this user" return cb(null, true) showAutoCompileOnboarding: (cb) -> cb = underscore.once(cb) @@ -275,7 +275,7 @@ module.exports = ProjectController = else if event? return cb(null, false) else - logger.log user_id, event, "autocompile onboarding not shown yet to this user" + logger.log { user_id, event }, "autocompile onboarding not shown yet to this user" return cb(null, true) }, (err, results)-> if err?