From 5bffc0d116bfad2473a852eaea368cc8207311a1 Mon Sep 17 00:00:00 2001
From: Antoine Clausse <antoine.clausse@overleaf.com>
Date: Wed, 13 Aug 2025 10:07:05 +0200
Subject: [PATCH] [web] Add admin permissions `modify-group` &
 `modify-managed-group` (#27456)

* Add capabilities `modify-group` and `modify-managed-group`

* Fix: Warning: validateDOMNesting(...): <span> cannot appear as a child of <option>

* Add `form-control` to select (fix styles)

* Check if admin can modify the group (frontend)

* Check if admin can modify the group (backend)

* Update tests

* Fix: Set `useSettingsUKAMF` state from `data?.useSettingsUKAMF`

* Add tests: Subscriptions update with adminRolesEnabled

* Use `getAdminCapabilities` helper

* Update `requireModifyGroupPermission` to array

Co-authored-by: Andrew Rumble <andrew.rumble@overleaf.com>

* Rename `canModify` to `canModifySubscription`

Co-authored-by: Andrew Rumble <andrew.rumble@overleaf.com>

* Refactor `requireModifyGroupPermission` stub

Co-authored-by: Andrew Rumble <andrew.rumble@overleaf.com>

* Test with `adminRolesEnabled` in SubscriptionDeletionTests.mjs

* Update test description with `adminRoles`

---------

Co-authored-by: Andrew Rumble <andrew.rumble@overleaf.com>
GitOrigin-RevId: 37b9a2e838fd566a33aa3a70631cebfd01b520ef
---
 .../web/test/acceptance/src/helpers/DeletedSubscription.mjs    | 3 +++
 services/web/types/admin-capabilities.ts                       | 2 ++
 2 files changed, 5 insertions(+)

diff --git a/services/web/test/acceptance/src/helpers/DeletedSubscription.mjs b/services/web/test/acceptance/src/helpers/DeletedSubscription.mjs
index 2d1c8f1f35..0ea1148b56 100644
--- a/services/web/test/acceptance/src/helpers/DeletedSubscription.mjs
+++ b/services/web/test/acceptance/src/helpers/DeletedSubscription.mjs
@@ -3,6 +3,7 @@ import MockSubscription from './Subscription.mjs'
 import SubscriptionUpdater from '../../../../app/src/Features/Subscription/SubscriptionUpdater.js'
 import { Subscription as SubscriptionModel } from '../../../../app/src/models/Subscription.js'
 import { DeletedSubscription as DeletedSubscriptionModel } from '../../../../app/src/models/DeletedSubscription.js'
+import { promisifyClass } from '@overleaf/promise-utils'
 
 class DeletedSubscription {
   constructor(options = {}) {
@@ -41,4 +42,6 @@ class DeletedSubscription {
   }
 }
 
+DeletedSubscription.promises = promisifyClass(DeletedSubscription)
+
 export default DeletedSubscription
diff --git a/services/web/types/admin-capabilities.ts b/services/web/types/admin-capabilities.ts
index 2200c73199..929a68ff6b 100644
--- a/services/web/types/admin-capabilities.ts
+++ b/services/web/types/admin-capabilities.ts
@@ -4,7 +4,9 @@ export type AdminCapability =
   | 'create-recurly-account'
   | 'create-subscription'
   | 'modify-feature-override'
+  | 'modify-group'
   | 'modify-login-status'
+  | 'modify-managed-group'
   | 'manage-survey'
   | 'modify-split-test'
   | 'modify-user-email'