From 5c94bd81e7d33cf82913c1304996a89b12f34889 Mon Sep 17 00:00:00 2001 From: Alf Eaton Date: Mon, 4 Jul 2022 09:29:54 +0100 Subject: [PATCH] Merge pull request #8699 from overleaf/ae-comment-threads Show tracked changes highlights if comment threads are not loaded GitOrigin-RevId: 1aabe62e1aea0b63336ab33cbf199c3f24471495 --- .../controllers/ReviewPanelController.js | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/services/web/frontend/js/ide/review-panel/controllers/ReviewPanelController.js b/services/web/frontend/js/ide/review-panel/controllers/ReviewPanelController.js index 1d51cb20fc..c692b41328 100644 --- a/services/web/frontend/js/ide/review-panel/controllers/ReviewPanelController.js +++ b/services/web/frontend/js/ide/review-panel/controllers/ReviewPanelController.js @@ -488,10 +488,15 @@ export default App.controller( } } - if (rangesTracker.comments.length > 0) { - if (!window.isRestrictedTokenMember) { - ensureThreadsAreLoaded() - } + if ( + rangesTracker.comments.length > 0 && + !window.isRestrictedTokenMember + ) { + ensureThreadsAreLoaded() + } else { + // ensure that tracked changes are highlighted even if no comments are loaded + ide.$scope.loadingThreads = false + dispatchReviewPanelEvent('loaded_threads') } for (const comment of Array.from(rangesTracker.comments)) {