From 61cd448832bce253e6ba24cfc71cb0c3004734d7 Mon Sep 17 00:00:00 2001 From: Simon Detheridge Date: Thu, 28 Mar 2019 15:00:54 +0000 Subject: [PATCH] Merge pull request #1672 from sharelatex/ns-input-autocomplete improve autocomplete when inserting over existing arguments GitOrigin-RevId: 8d1401cca141348dd33b965c92e120cf66350d7e --- .../aceEditor/auto-complete/AutoCompleteManager.js | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/services/web/public/src/ide/editor/directives/aceEditor/auto-complete/AutoCompleteManager.js b/services/web/public/src/ide/editor/directives/aceEditor/auto-complete/AutoCompleteManager.js index 24f2b6e872..7c2f03e438 100644 --- a/services/web/public/src/ide/editor/directives/aceEditor/auto-complete/AutoCompleteManager.js +++ b/services/web/public/src/ide/editor/directives/aceEditor/auto-complete/AutoCompleteManager.js @@ -382,6 +382,20 @@ define([ ) } } + const inArgument = lineBeyondCursor.match( + /^([\w._-]+)\}(.*)/ + ) + if (inArgument) { + const argumentRightOfCursor = inArgument[1] + const afterArgument = inArgument[2] + if (afterArgument) { + rightRange.end.column = + rightRange.start.column + + argumentRightOfCursor.length + + 1 + } + editor.session.remove(rightRange) + } } } // finally, insert the match