From 63d7e9bc1b1b56916e69d58ace68fb68fd9fb9dd Mon Sep 17 00:00:00 2001 From: Jakob Ackermann Date: Wed, 25 Aug 2021 10:24:52 +0200 Subject: [PATCH] Merge pull request #4874 from overleaf/jpa-web-recurly-unhandled [web] emit error object instead of string from RecurlyWrapper.apiRequest GitOrigin-RevId: 9fd6cac0b763a438063fdeb1f06bdaa4920024d9 --- .../web/app/src/Features/Subscription/RecurlyWrapper.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/services/web/app/src/Features/Subscription/RecurlyWrapper.js b/services/web/app/src/Features/Subscription/RecurlyWrapper.js index 3a7fd2a936..31c0f33e3e 100644 --- a/services/web/app/src/Features/Subscription/RecurlyWrapper.js +++ b/services/web/app/src/Features/Subscription/RecurlyWrapper.js @@ -467,8 +467,10 @@ const RecurlyWrapper = { }, 'error returned from recurly' ) - // TODO: this should be an Error object not a string - error = `Recurly API returned with status code: ${response.statusCode}` + error = new OError( + `Recurly API returned with status code: ${response.statusCode}`, + { statusCode: response.statusCode } + ) } return callback(error, response, body) })