From 645132c53b91ad27c6ca8c6ef36cdf1f5a4c8695 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Timoth=C3=A9e=20Alby?= <timothee.alby@gmail.com>
Date: Tue, 21 Dec 2021 14:45:38 +0100
Subject: [PATCH] Merge pull request #6056 from
 overleaf/msm-remove-unnecessary-pdf-event-tracking

Cleanup PDF Preview event tracking

GitOrigin-RevId: 8fadaee2759f60e70e27ac417593d35cc73e8b68
---
 .../js/features/pdf-preview/util/compiler.js         |  4 ----
 .../frontend/js/ide/pdf/controllers/PdfController.js |  9 ---------
 .../js/ide/pdf/controllers/PdfSynctexController.js   |  3 ---
 .../frontend/js/shared/context/compile-context.js    | 12 +-----------
 4 files changed, 1 insertion(+), 27 deletions(-)

diff --git a/services/web/frontend/js/features/pdf-preview/util/compiler.js b/services/web/frontend/js/features/pdf-preview/util/compiler.js
index cc82aee873..b188704633 100644
--- a/services/web/frontend/js/features/pdf-preview/util/compiler.js
+++ b/services/web/frontend/js/features/pdf-preview/util/compiler.js
@@ -1,6 +1,5 @@
 import { isMainFile } from './editor-files'
 import getMeta from '../../../utils/meta'
-import { sendMBSampled } from '../../../infrastructure/event-tracking'
 import { deleteJSON, postJSON } from '../../../infrastructure/fetch-json'
 import { debounce } from 'lodash'
 import { trackPdfDownload } from '../../../ide/pdf/controllers/PdfJsMetrics'
@@ -74,9 +73,6 @@ export default class DocumentCompiler {
     }
 
     try {
-      // log a sample of the compile requests
-      sendMBSampled('editor-recompile-sampled', options)
-
       // reset values
       this.setChangedAt(0)
       this.validationIssues = undefined
diff --git a/services/web/frontend/js/ide/pdf/controllers/PdfController.js b/services/web/frontend/js/ide/pdf/controllers/PdfController.js
index 20fc5f917f..99bfae8ed6 100644
--- a/services/web/frontend/js/ide/pdf/controllers/PdfController.js
+++ b/services/web/frontend/js/ide/pdf/controllers/PdfController.js
@@ -244,9 +244,6 @@ App.controller(
           autoCompileIfReady()
         }
         localStorage(`autocompile_enabled:${$scope.project_id}`, newValue)
-        eventTracking.sendMB('autocompile-setting-changed', {
-          value: newValue,
-        })
       }
     })
 
@@ -472,9 +469,6 @@ App.controller(
           $scope.pdf.view = 'errors'
           $scope.pdf.autoCompileDisabled = true
           $scope.autocompile_enabled = false // disable any further autocompiles
-          eventTracking.sendMB('autocompile-rate-limited', {
-            hasPremiumCompile: $scope.hasPremiumCompile,
-          })
         }
       } else if (response.status === 'project-too-large') {
         $scope.pdf.view = 'errors'
@@ -785,8 +779,6 @@ App.controller(
         return
       }
 
-      eventTracking.sendMBSampled('editor-recompile-sampled', options)
-
       $scope.lastStartedCompileAt = Date.now()
       $scope.pdf.compiling = true
       $scope.pdf.isAutoCompileOnLoad =
@@ -959,7 +951,6 @@ App.controller(
 
     $scope.openInEditor = function (entry) {
       let column, line
-      eventTracking.sendMBOnce('logs-jump-to-location-once')
       const entity = ide.fileTreeManager.findEntityByPath(entry.file)
       if (entity == null || entity.type !== 'doc') {
         return
diff --git a/services/web/frontend/js/ide/pdf/controllers/PdfSynctexController.js b/services/web/frontend/js/ide/pdf/controllers/PdfSynctexController.js
index 7c6c0f1fab..02a25768e3 100644
--- a/services/web/frontend/js/ide/pdf/controllers/PdfSynctexController.js
+++ b/services/web/frontend/js/ide/pdf/controllers/PdfSynctexController.js
@@ -1,5 +1,4 @@
 import App from '../../../base'
-import { sendMBOnce } from '../../../infrastructure/event-tracking'
 
 App.controller('PdfSynctexController', function ($scope, synctex, ide) {
   this.cursorPosition = null
@@ -50,8 +49,6 @@ App.controller('PdfSynctexController', function ($scope, synctex, ide) {
   })
 
   window.addEventListener('synctex:sync-to-entry', event => {
-    sendMBOnce('logs-jump-to-location-once')
-
     const entry = event.detail
 
     const entity = ide.fileTreeManager.findEntityByPath(entry.file)
diff --git a/services/web/frontend/js/shared/context/compile-context.js b/services/web/frontend/js/shared/context/compile-context.js
index f4fe44d9a3..8b805eaa9c 100644
--- a/services/web/frontend/js/shared/context/compile-context.js
+++ b/services/web/frontend/js/shared/context/compile-context.js
@@ -134,7 +134,7 @@ export function CompileProvider({ children }) {
   const [position, setPosition] = usePersistedState(`pdf.position.${projectId}`)
 
   // whether autocompile is switched on
-  const [autoCompile, _setAutoCompile] = usePersistedState(
+  const [autoCompile, setAutoCompile] = usePersistedState(
     `autocompile_enabled:${projectId}`,
     false,
     true
@@ -202,15 +202,6 @@ export function CompileProvider({ children }) {
     }
   }, [setUncompiled, changedAt])
 
-  // record changes to the autocompile setting
-  const setAutoCompile = useCallback(
-    value => {
-      _setAutoCompile(value)
-      sendMB('autocompile-setting-changed', { value })
-    },
-    [_setAutoCompile]
-  )
-
   // always compile the PDF once after opening the project, after the doc has loaded
   useEffect(() => {
     if (!compiledOnce && currentDoc) {
@@ -293,7 +284,6 @@ export function CompileProvider({ children }) {
           if (!data.options.isAutoCompileOnLoad) {
             setError('autocompile-disabled')
             setAutoCompile(false)
-            sendMB('autocompile-rate-limited', { hasPremiumCompile })
           }
           break