From 6569f49a92d75c26d6ced481f166ba73c7d1a423 Mon Sep 17 00:00:00 2001 From: Alf Eaton Date: Tue, 21 May 2024 12:35:07 +0100 Subject: [PATCH] Set isEvalSupported to false when loading a PDF document (#18444) GitOrigin-RevId: 394d63571d83302b91b5719389adf49155218bc7 --- .../js/features/file-view/components/file-view-pdf.tsx | 5 ++++- .../frontend/js/features/pdf-preview/util/pdf-js-wrapper.js | 1 + .../extensions/visual/visual-widgets/graphics.ts | 2 +- 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/services/web/frontend/js/features/file-view/components/file-view-pdf.tsx b/services/web/frontend/js/features/file-view/components/file-view-pdf.tsx index 4d3b80bb9a..3efc61a219 100644 --- a/services/web/frontend/js/features/file-view/components/file-view-pdf.tsx +++ b/services/web/frontend/js/features/file-view/components/file-view-pdf.tsx @@ -33,7 +33,10 @@ const FileViewPdf: FC<{ return } - const pdf = await PDFJS.getDocument(preview.url).promise + const pdf = await PDFJS.getDocument({ + url: preview.url, + isEvalSupported: false, + }).promise // bail out if loading the PDF took too long if (!mountedRef.current) { diff --git a/services/web/frontend/js/features/pdf-preview/util/pdf-js-wrapper.js b/services/web/frontend/js/features/pdf-preview/util/pdf-js-wrapper.js index 9b419b1397..6a92630a21 100644 --- a/services/web/frontend/js/features/pdf-preview/util/pdf-js-wrapper.js +++ b/services/web/frontend/js/features/pdf-preview/util/pdf-js-wrapper.js @@ -96,6 +96,7 @@ export default class PDFJSWrapper { rangeChunkSize, disableAutoFetch: true, disableStream, + isEvalSupported: false, textLayerMode: 2, // PDFJSViewer.TextLayerMode.ENABLE, range: rangeTransport, }) diff --git a/services/web/frontend/js/features/source-editor/extensions/visual/visual-widgets/graphics.ts b/services/web/frontend/js/features/source-editor/extensions/visual/visual-widgets/graphics.ts index 7321f9e02b..f6c744aaec 100644 --- a/services/web/frontend/js/features/source-editor/extensions/visual/visual-widgets/graphics.ts +++ b/services/web/frontend/js/features/source-editor/extensions/visual/visual-widgets/graphics.ts @@ -143,7 +143,7 @@ export class GraphicsWidget extends WidgetType { return } - const pdf = await PDFJS.getDocument(url).promise + const pdf = await PDFJS.getDocument({ url, isEvalSupported: false }).promise const page = await pdf.getPage(1) // bail out if loading the PDF took too long