From 67632212d7da6d8ff900245fa41cfdb792284799 Mon Sep 17 00:00:00 2001 From: Domagoj Kriskovic Date: Thu, 3 Aug 2023 13:59:18 +0200 Subject: [PATCH] [cm6] show full title for section outline (#14100) * [cm6] prefer showing full title in outline for sections * fix test * remove fallback * test rename GitOrigin-RevId: ac7a2a2c4fa7740a51661710953c85f03394292f --- .../features/source-editor/utils/tree-operations/outline.ts | 4 +--- .../source-editor/languages/latex/latex-outline.test.ts | 4 ++-- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/services/web/frontend/js/features/source-editor/utils/tree-operations/outline.ts b/services/web/frontend/js/features/source-editor/utils/tree-operations/outline.ts index d43f1d2bd6..696610015c 100644 --- a/services/web/frontend/js/features/source-editor/utils/tree-operations/outline.ts +++ b/services/web/frontend/js/features/source-editor/utils/tree-operations/outline.ts @@ -114,9 +114,7 @@ export const enterNode = ( // This should already be in `items` return } - const name = - command.getChild('OptionalArgument')?.getChild('ShortOptionalArg') ?? - command.getChild('SectioningArgument')?.getChild('LongArg') + const name = command.getChild('SectioningArgument')?.getChild('LongArg') if (name == null || command == null) { return diff --git a/services/web/test/frontend/features/source-editor/languages/latex/latex-outline.test.ts b/services/web/test/frontend/features/source-editor/languages/latex/latex-outline.test.ts index 870f189bce..2547c6441a 100644 --- a/services/web/test/frontend/features/source-editor/languages/latex/latex-outline.test.ts +++ b/services/web/test/frontend/features/source-editor/languages/latex/latex-outline.test.ts @@ -435,13 +435,13 @@ describe('CodeMirror LaTeX-FileOutline', function () { view = makeView(content) }) - it('should use the optional argument as title', function () { + it('should use the long argument as title', function () { const outline = getOutline(view) expect(outline).to.deep.equal([ { from: 0, to: 30, - title: 'short title', + title: 'section', line: 1, level: SECTION_LEVEL, },