From 696e9d27d68849cdb2cc98bb9395fe7ca48e9e09 Mon Sep 17 00:00:00 2001 From: Henry Oswald Date: Wed, 7 Feb 2018 14:28:49 +0000 Subject: [PATCH] send invalid_email error type down when sharing project --- .../Features/Collaborators/CollaboratorsInviteController.coffee | 2 +- .../ide/share/controllers/ShareProjectModalController.coffee | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/services/web/app/coffee/Features/Collaborators/CollaboratorsInviteController.coffee b/services/web/app/coffee/Features/Collaborators/CollaboratorsInviteController.coffee index 28f0cbb5ee..898abe52bb 100644 --- a/services/web/app/coffee/Features/Collaborators/CollaboratorsInviteController.coffee +++ b/services/web/app/coffee/Features/Collaborators/CollaboratorsInviteController.coffee @@ -65,7 +65,7 @@ module.exports = CollaboratorsInviteController = email = EmailHelper.parseEmail(email) if !email? or email == "" logger.log {projectId, email, sendingUserId}, "invalid email address" - return res.sendStatus(400) + return res.status(400).send({errorReason:"invalid_email"}) CollaboratorsInviteController._checkRateLimit sendingUserId, (error, underRateLimit) -> return next(error) if error? if !underRateLimit diff --git a/services/web/public/coffee/ide/share/controllers/ShareProjectModalController.coffee b/services/web/public/coffee/ide/share/controllers/ShareProjectModalController.coffee index 0a091dae0b..b26bef3c06 100644 --- a/services/web/public/coffee/ide/share/controllers/ShareProjectModalController.coffee +++ b/services/web/public/coffee/ide/share/controllers/ShareProjectModalController.coffee @@ -134,8 +134,6 @@ define [ if data?.errorReason? $scope.state.errorReason = data?.errorReason - else if status? and status == 400 - $scope.state.errorReason = 'invalid_email' else $scope.state.errorReason = null