From e41a48de7253ee277b73f43a6918dba6575bfa3e Mon Sep 17 00:00:00 2001 From: Paulo Reis Date: Thu, 28 Sep 2017 14:01:03 +0100 Subject: [PATCH 1/2] Conditionally disable text-shadow on chrome v61 and v62. --- services/web/public/coffee/ide.coffee | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/services/web/public/coffee/ide.coffee b/services/web/public/coffee/ide.coffee index e317b355ef..357b45224e 100644 --- a/services/web/public/coffee/ide.coffee +++ b/services/web/public/coffee/ide.coffee @@ -185,6 +185,21 @@ define [ if ide.browserIsSafari ide.safariScrollPatcher = new SafariScrollPatcher($scope) + # Fix Chrome 61 and 62 text-shadow rendering + browserIsChrome61or62 = false + try + chromeVersion = parseFloat(navigator.userAgent.split(" Chrome/")[1]) || null; + browserIsChrome61or62 = ( + chromeVersion? && + (chromeVersion == 61 || chromeVersion == 62) + ) + console.log chromeVersion, browserIsChrome61or62 + if browserIsChrome61or62 + document.styleSheets[0].insertRule(".ace_editor.ace_autocomplete .ace_completion-highlight { text-shadow: none !important; }", 1) + catch err + console.error err + + # User can append ?ft=somefeature to url to activate a feature toggle ide.featureToggle = location?.search?.match(/^\?ft=(\w+)$/)?[1] From 65d38aa7f7b2df09529613abc74b49d7add4cd00 Mon Sep 17 00:00:00 2001 From: Paulo Reis Date: Thu, 28 Sep 2017 14:09:37 +0100 Subject: [PATCH 2/2] Remove debug line. --- services/web/public/coffee/ide.coffee | 1 - 1 file changed, 1 deletion(-) diff --git a/services/web/public/coffee/ide.coffee b/services/web/public/coffee/ide.coffee index 357b45224e..06201bd0b1 100644 --- a/services/web/public/coffee/ide.coffee +++ b/services/web/public/coffee/ide.coffee @@ -193,7 +193,6 @@ define [ chromeVersion? && (chromeVersion == 61 || chromeVersion == 62) ) - console.log chromeVersion, browserIsChrome61or62 if browserIsChrome61or62 document.styleSheets[0].insertRule(".ace_editor.ace_autocomplete .ace_completion-highlight { text-shadow: none !important; }", 1) catch err