agw/overleaf-cep
1
0
Fork 0
mirror of https://github.com/yu-i-i/overleaf-cep.git synced 2026-06-09 09:09:02 +02:00
Code Issues Packages Projects Releases Wiki Activity

[project-history] migrate from joi to zod (#30187)

Browse Source 
* Add @overleaf/validation-tools in project-history

* use error handler for zod

* Replace joi validations with zod schema

* fix unit tests

* remove Joi validation middleware

* remove optional when there is a default

* fix tests after checking for objectid

* ran build_scripts

* monorepo npm install

GitOrigin-RevId: f8396a3caadd536edf64c6f971c77f4c941f000a
This commit is contained in:
Domagoj Kriskovic
2026-01-12 13:38:10 +01:00
committed by Copybot
parent 18cff6e1ac
commit 6d3dd3601a
9 changed files with 312 additions and 223 deletions
Download Patch File Download Diff File Expand all files Collapse all files
services/project-history/test/unit/js/HttpController/HttpControllerTests.js
+8 -6
View File
@@ -92,7 +92,7 @@ describe('HttpController', function () {
beforeEach(function () {
this.blobHash = 'abcd'
this.stream = {}
this.historyId = 1337
this.historyId = new ObjectId().toString()
this.HistoryStoreManager.getProjectBlobStream.yields(null, this.stream)
this.HttpController.getProjectBlob(
{ params: { history_id: this.historyId, hash: this.blobHash } },
@@ -414,7 +414,7 @@ describe('HttpController', function () {
project_id: this.projectId,
},
body: {
version: (this.version = 'label-1'),
version: (this.version = 1),
comment: (this.comment = 'a comment'),
created_at: (this.created_at = Date.now().toString()),
validate_exists: true,
@@ -486,11 +486,12 @@ describe('HttpController', function () {
describe('deleteLabelForUser', function () {
beforeEach(function () {
this.label_id = new ObjectId()
this.req = {
params: {
project_id: this.projectId,
user_id: this.userId,
label_id: (this.label_id = new ObjectId()),
label_id: this.label_id.toString(),
},
}
this.HttpController.deleteLabelForUser(this.req, this.res, this.next)
@@ -498,7 +499,7 @@ describe('HttpController', function () {
it('should delete a label for a project', function () {
this.LabelsManager.deleteLabelForUser
.calledWith(this.projectId, this.userId, this.label_id)
.calledWith(this.projectId, this.userId, this.label_id.toString())
.should.equal(true)
})
@@ -509,10 +510,11 @@ describe('HttpController', function () {
describe('deleteLabel', function () {
beforeEach(function () {
this.label_id = new ObjectId()
this.req = {
params: {
project_id: this.projectId,
label_id: (this.label_id = new ObjectId()),
label_id: this.label_id.toString(),
},
}
this.HttpController.deleteLabel(this.req, this.res, this.next)
@@ -520,7 +522,7 @@ describe('HttpController', function () {
it('should delete a label for a project', function () {
this.LabelsManager.deleteLabel
.calledWith(this.projectId, this.label_id)
.calledWith(this.projectId, this.label_id.toString())
.should.equal(true)
})