From 6da840dd8f2041cf7ec920ccdbb9c91d0a094302 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Timoth=C3=A9e=20Alby?= <timothee.alby@gmail.com>
Date: Mon, 30 May 2022 12:18:44 +0200
Subject: [PATCH] Merge pull request #8199 from overleaf/ii-settings-ts-fixes

[web] Fix TS errors in settings area

GitOrigin-RevId: 48f3695570bd794b4865bd45a29aa6fc9bf57502
---
 .../settings/components/emails/add-email.tsx     |  3 ++-
 .../components/emails/add-email/input.tsx        | 16 +++++++++++-----
 .../settings/components/emails/email.tsx         |  2 +-
 3 files changed, 14 insertions(+), 7 deletions(-)

diff --git a/services/web/frontend/js/features/settings/components/emails/add-email.tsx b/services/web/frontend/js/features/settings/components/emails/add-email.tsx
index ffa8e86bb7..db0914c0eb 100644
--- a/services/web/frontend/js/features/settings/components/emails/add-email.tsx
+++ b/services/web/frontend/js/features/settings/components/emails/add-email.tsx
@@ -120,7 +120,8 @@ function AddEmail() {
             />
           </Cell>
         </Col>
-        {ssoAvailableForDomain(newEmailMatchedDomain) ? (
+        {newEmailMatchedDomain &&
+        ssoAvailableForDomain(newEmailMatchedDomain) ? (
           <Col md={8}>
             <Cell>
               <SsoLinkingInfo
diff --git a/services/web/frontend/js/features/settings/components/emails/add-email/input.tsx b/services/web/frontend/js/features/settings/components/emails/add-email/input.tsx
index 1de8743a04..9119d4414c 100644
--- a/services/web/frontend/js/features/settings/components/emails/add-email/input.tsx
+++ b/services/web/frontend/js/features/settings/components/emails/add-email/input.tsx
@@ -125,11 +125,17 @@ function Input({ onChange, handleAddNewEmail }: InputProps) {
 
         if (suggestion) {
           setInputValueAndResetSuggestion()
-        } else {
-          const match = matchLocalAndDomain(inputValue)
-          if (match.local && match.domain) {
-            handleAddNewEmail()
-          }
+
+          return
+        }
+
+        if (!inputValue) {
+          return
+        }
+
+        const match = matchLocalAndDomain(inputValue)
+        if (match.local && match.domain) {
+          handleAddNewEmail()
         }
       }
 
diff --git a/services/web/frontend/js/features/settings/components/emails/email.tsx b/services/web/frontend/js/features/settings/components/emails/email.tsx
index e227604e92..a05850513a 100644
--- a/services/web/frontend/js/features/settings/components/emails/email.tsx
+++ b/services/web/frontend/js/features/settings/components/emails/email.tsx
@@ -11,7 +11,7 @@ function Email({ userEmailData }: EmailProps) {
   const { t } = useTranslation()
 
   const ssoAvailable = ssoAvailableForInstitution(
-    userEmailData.affiliation?.institution
+    userEmailData.affiliation?.institution || null
   )
 
   return (