From 6dc54df48a4e59a00999b8902f030da8aea3a854 Mon Sep 17 00:00:00 2001 From: Mathias Jakobsen Date: Thu, 11 Sep 2025 09:42:20 +0100 Subject: [PATCH] Merge pull request #28427 from overleaf/mj-error-log-narrow [web] Improve redesigned error logs on narrow screens GitOrigin-RevId: f9c4f577f3dcd1acb3eb9c5df6295b26b85b4b2f --- .../error-logs/log-entry-header.tsx | 62 +++++++++---------- .../components/rail/rail-panel.tsx | 2 +- .../stylesheets/pages/editor/logs.scss | 17 ++++- 3 files changed, 43 insertions(+), 38 deletions(-) diff --git a/services/web/frontend/js/features/ide-redesign/components/error-logs/log-entry-header.tsx b/services/web/frontend/js/features/ide-redesign/components/error-logs/log-entry-header.tsx index 323a34a52e..3c2bb87280 100644 --- a/services/web/frontend/js/features/ide-redesign/components/error-logs/log-entry-header.tsx +++ b/services/web/frontend/js/features/ide-redesign/components/error-logs/log-entry-header.tsx @@ -107,41 +107,35 @@ function LogEntryHeader({ return (
- - - + +
+

{headerTitleText}

+ {locationSpanOverflown && formattedLocationText && locationText ? ( + + {formattedLocationText} + + ) : ( + formattedLocationText + )} +
+ {actionButtonsOverride ?? (
diff --git a/services/web/frontend/js/features/ide-redesign/components/rail/rail-panel.tsx b/services/web/frontend/js/features/ide-redesign/components/rail/rail-panel.tsx index 8d6e2285c8..3b8902ca9c 100644 --- a/services/web/frontend/js/features/ide-redesign/components/rail/rail-panel.tsx +++ b/services/web/frontend/js/features/ide-redesign/components/rail/rail-panel.tsx @@ -36,7 +36,7 @@ export default function RailPanel({ id={`ide-redesign-sidebar-panel-${isHistoryView ? 'file-tree' : selectedTab}`} className={classNames({ hidden: isReviewPanelOpen })} order={1} - defaultSize={15} + defaultSize={selectedTab === 'errors' ? 20 : 15} minSize={5} maxSize={80} ref={panelRef} diff --git a/services/web/frontend/stylesheets/pages/editor/logs.scss b/services/web/frontend/stylesheets/pages/editor/logs.scss index 4f2d4146bf..92b640a042 100644 --- a/services/web/frontend/stylesheets/pages/editor/logs.scss +++ b/services/web/frontend/stylesheets/pages/editor/logs.scss @@ -78,7 +78,9 @@ display: flex; align-items: center; border: none; - gap: var(--spacing-03); + flex-wrap: wrap; + container-type: inline-size; + column-gap: var(--spacing-03); } .log-entry-header-button { @@ -88,7 +90,7 @@ align-items: center; flex: 1; border-radius: var(--border-radius-base); - padding: var(--spacing-02) var(--spacing-03) var(--spacing-02) 0; + padding: var(--spacing-02) 0; overflow: hidden; user-select: text; @@ -152,7 +154,16 @@ .log-entry-header-actions { display: flex; - gap: var(--spacing-03); + } + + @container (width <= 250px) { + .log-entry-header-actions { + padding-left: var(--spacing-06); + } + + .log-entry-header-button { + min-width: 100%; + } } .log-entry-content-button-container {