mirror of
https://github.com/yu-i-i/overleaf-cep.git
synced 2026-11-12 13:13:45 +01:00
Replace placeholders with labels (#26811)
* Replace placeholders for labels * Remove redundant aria-label and update labels with `.visually-hidden` * Change "Invite more members" to a label * Fix helper text for group members and fix responsiveness * Change error message to an error notification * Use label and helper text instead of a placeholder * Remove redundant label and use the placeholder text instead for the admin user searchbar * Extract translations GitOrigin-RevId: a504fda9779da82920b57c7b8aad38a8b027d09a
This commit is contained in:
@@ -106,7 +106,7 @@ describe('filestore migration', function () {
|
||||
name: /Create First Project|New Project/,
|
||||
}).click()
|
||||
cy.findByRole('link', { name: 'Example Project' }).click()
|
||||
cy.findByPlaceholderText('Project Name').type(projectName)
|
||||
cy.findByLabelText(/Project name/i).type(projectName)
|
||||
cy.findByRole('button', { name: 'Create' }).click()
|
||||
cy.url()
|
||||
.should('match', /\/project\/[a-fA-F0-9]{24}/)
|
||||
|
||||
@@ -106,8 +106,10 @@ function shareProjectByEmail(
|
||||
openProjectByName(projectName)
|
||||
cy.findByText('Share').click()
|
||||
cy.findByRole('dialog').within(() => {
|
||||
cy.findByLabelText('Add people', { selector: 'input' }).type(`${email},`)
|
||||
cy.findByLabelText('Add people', { selector: 'input' })
|
||||
cy.findByLabelText('Add email address', { selector: 'input' }).type(
|
||||
`${email},`
|
||||
)
|
||||
cy.findByLabelText('Add email address', { selector: 'input' })
|
||||
.parents('form')
|
||||
.within(() => {
|
||||
cy.findByTestId('add-collaborator-select')
|
||||
|
||||
@@ -21,7 +21,9 @@ describe('History', function () {
|
||||
cy.findByText('Label this version').click()
|
||||
})
|
||||
cy.findByRole('dialog').within(() => {
|
||||
cy.get('input[placeholder="New label name"]').type(`${name}{enter}`)
|
||||
cy.findByLabelText(/New label name/i)
|
||||
.as('input')
|
||||
.type(`${name}{enter}`)
|
||||
})
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user