Merge pull request #34923 from overleaf/mj-left-menu-field

[web] Clean up "left menu" concepts in new editor

GitOrigin-RevId: 9597c1c53af15f3a1587e62176bca36cd7c9069c

services/web/frontend/js/features/ide-react/components/rail/rail.tsx

@@ -73,7 +73,7 @@ export const RailLayout = () => {
   const gitBridgeEnabled = getMeta('ol-gitBridgeEnabled')
   const { isOverleaf } = getMeta('ol-ExposedSettings')
 
-  const { view, setLeftMenuShown, focusMode } = useLayoutContext()
+  const { view, setSettingsShown, focusMode } = useLayoutContext()
 
   const { markMessagesAsRead } = useChatContext()
 
@@ -166,11 +166,11 @@ export const RailLayout = () => {
         title: t('settings'),
         action: () => {
           sendEvent('rail-click', { tab: 'settings' })
-          setLeftMenuShown(true)
+          setSettingsShown(true)
         },
       },
     ],
-    [setLeftMenuShown, t, sendEvent]
+    [setSettingsShown, t, sendEvent]
   )
 
   useCommandProvider(
@@ -178,13 +178,13 @@ export const RailLayout = () => {
       {
         id: 'open-settings',
         handler: () => {
-          setLeftMenuShown(true)
+          setSettingsShown(true)
         },
         menuLabel: t('settings'),
         label: t('open_settings'),
       },
     ],
-    [t, setLeftMenuShown]
+    [t, setSettingsShown]
   )
 
   const onTabSelect = useCallback(

services/web/frontend/js/features/ide-react/hooks/use-layout-event-tracking.ts

@@ -3,7 +3,7 @@ import { useEffect } from 'react'
 import { sendMBOnce } from '@/infrastructure/event-tracking'
 
 export function useLayoutEventTracking() {
-  const { view, leftMenuShown, chatIsOpen } = useLayoutContext()
+  const { view, settingsShown, chatIsOpen } = useLayoutContext()
 
   useEffect(() => {
     if (view && view !== 'editor' && view !== 'pdf') {
@@ -12,10 +12,10 @@ export function useLayoutEventTracking() {
   }, [view])
 
   useEffect(() => {
-    if (leftMenuShown) {
+    if (settingsShown) {
       sendMBOnce(`ide-open-left-menu-once`)
     }
-  }, [leftMenuShown])
+  }, [settingsShown])
 
   useEffect(() => {
     if (chatIsOpen) {