agw/overleaf-cep
1
0
Fork 0
mirror of https://github.com/yu-i-i/overleaf-cep.git synced 2026-05-23 17:19:37 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #21462 from overleaf/revert-18828-ac-node-20

Browse Source 
Revert "Upgrade Node from `18.20.2` to `20.17.0`"

GitOrigin-RevId: cc12c33b4588caa2959817a113547d20d437d6f4
This commit is contained in:
Andrew Rumble
2024-10-29 14:51:59 +00:00
committed by Copybot
parent 8f56f39ec8
commit 79d80cc266
87 changed files with 109 additions and 113 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
services/contacts/.nvmrc
View File

@@ -1 +1 @@
20.18.0
18.20.2

2
services/contacts/Dockerfile
View File

@@ -2,7 +2,7 @@
# Instead run bin/update_build_scripts from
# https://github.com/overleaf/internal/
FROM node:20.18.0 AS base
FROM node:18.20.2 AS base
WORKDIR /overleaf/services/contacts

4
services/contacts/Makefile
View File

@@ -32,12 +32,12 @@ HERE=$(shell pwd)
MONOREPO=$(shell cd ../../ && pwd)
# Run the linting commands in the scope of the monorepo.
# Eslint and prettier (plus some configs) are on the root.
RUN_LINTING = docker run --rm -v $(MONOREPO):$(MONOREPO) -w $(HERE) node:20.18.0 npm run --silent
RUN_LINTING = docker run --rm -v $(MONOREPO):$(MONOREPO) -w $(HERE) node:18.20.2 npm run --silent
RUN_LINTING_CI = docker run --rm --volume $(MONOREPO)/.editorconfig:/overleaf/.editorconfig --volume $(MONOREPO)/.eslintignore:/overleaf/.eslintignore --volume $(MONOREPO)/.eslintrc:/overleaf/.eslintrc --volume $(MONOREPO)/.prettierignore:/overleaf/.prettierignore --volume $(MONOREPO)/.prettierrc:/overleaf/.prettierrc --volume $(MONOREPO)/tsconfig.backend.json:/overleaf/tsconfig.backend.json ci/$(PROJECT_NAME):$(BRANCH_NAME)-$(BUILD_NUMBER) npm run --silent
# Same but from the top of the monorepo
RUN_LINTING_MONOREPO = docker run --rm -v $(MONOREPO):$(MONOREPO) -w $(MONOREPO) node:20.18.0 npm run --silent
RUN_LINTING_MONOREPO = docker run --rm -v $(MONOREPO):$(MONOREPO) -w $(MONOREPO) node:18.20.2 npm run --silent
format:
$(RUN_LINTING) format

2
services/contacts/buildscript.txt
View File

@@ -4,6 +4,6 @@ contacts
--env-add=
--env-pass-through=
--esmock-loader=True
--node-version=20.18.0
--node-version=18.20.2
--public-repo=False
--script-version=4.5.0

4
services/contacts/docker-compose.yml
View File

@@ -6,7 +6,7 @@ version: "2.3"
services:
test_unit:
image: node:20.18.0
image: node:18.20.2
volumes:
- .:/overleaf/services/contacts
- ../../node_modules:/overleaf/node_modules
@@ -20,7 +20,7 @@ services:
user: node
test_acceptance:
image: node:20.18.0
image: node:18.20.2
volumes:
- .:/overleaf/services/contacts
- ../../node_modules:/overleaf/node_modules