From 7b1a728e007412c09d8e0b5bb48136a3ba207c51 Mon Sep 17 00:00:00 2001
From: Rebeka Dekany <50901361+rebekadekany@users.noreply.github.com>
Date: Wed, 27 Sep 2023 12:55:21 +0200
Subject: [PATCH] Merge pull request #14968 from
 overleaf/rd-report-footer-heading

Accessibility - Semantic heading markup for footer titles

GitOrigin-RevId: e534835ba2ad21e91bd396120444ee05fcc02c6a
---
 services/web/app/views/layout/fat-footer.pug           | 10 +++++-----
 .../web/frontend/stylesheets/components/footer.less    |  1 +
 2 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/services/web/app/views/layout/fat-footer.pug b/services/web/app/views/layout/fat-footer.pug
index 6d4cd2f49e..8007fec758 100644
--- a/services/web/app/views/layout/fat-footer.pug
+++ b/services/web/app/views/layout/fat-footer.pug
@@ -7,7 +7,7 @@ footer.fat-footer.hidden-print
 				a(href='/', aria-label=settings.appName).footer-brand
 					
 			.footer-section
-				.footer-section-heading #{translate('About')}
+				h2.footer-section-heading #{translate('About')}
 					
 				ul.list-unstyled
 					li
@@ -22,7 +22,7 @@ footer.fat-footer.hidden-print
 						a(href="/blog") #{translate('blog')}
 						
 			.footer-section
-				.footer-section-heading #{translate('learn')}
+				h2.footer-section-heading #{translate('learn')}
 		
 				ul.list-unstyled
 					li
@@ -39,7 +39,7 @@ footer.fat-footer.hidden-print
 						a(href="/learn/latex/Tables") #{translate('how_to_create_tables')}
 						
 			.footer-section
-				.footer-section-heading !{translate('footer_plans_and_pricing')}
+				h2.footer-section-heading !{translate('footer_plans_and_pricing')}
 		
 				ul.list-unstyled
 					li
@@ -57,7 +57,7 @@ footer.fat-footer.hidden-print
 						a(href="/user/subscription/plans?itm_referrer=footer-for-students#view=student") #{translate('for_students')}
 						
 			.footer-section
-				.footer-section-heading #{translate('get_involved')}
+				h2.footer-section-heading #{translate('get_involved')}
 		
 				ul.list-unstyled
 					li
@@ -71,7 +71,7 @@ footer.fat-footer.hidden-print
 							a(href="/user/bonus") #{translate('refer_a_friend')}
 		
 			.footer-section
-				.footer-section-heading #{translate('help')}
+				h2.footer-section-heading #{translate('help')}
 		
 				ul.list-unstyled
 					li
diff --git a/services/web/frontend/stylesheets/components/footer.less b/services/web/frontend/stylesheets/components/footer.less
index 9f243fd223..f083aadf9f 100644
--- a/services/web/frontend/stylesheets/components/footer.less
+++ b/services/web/frontend/stylesheets/components/footer.less
@@ -86,6 +86,7 @@ footer.site-footer {
   }
 
   .footer-section-heading {
+    color: @neutral-20;
     font-family: @font-family-serif;
     font-size: @font-size-h3;
     line-height: @headings-line-height;