From 7cf5db4c638f8bb4e491adb7d872d88cf01cc418 Mon Sep 17 00:00:00 2001 From: James Allen Date: Wed, 25 Jan 2017 14:47:45 +0100 Subject: [PATCH] No need to return message after editing --- .../app/coffee/Features/Messages/MessageHttpController.coffee | 2 +- .../chat/app/coffee/Features/Messages/MessageManager.coffee | 4 +--- .../chat/test/acceptance/coffee/EditingAMessageTests.coffee | 4 +--- 3 files changed, 3 insertions(+), 7 deletions(-) diff --git a/services/chat/app/coffee/Features/Messages/MessageHttpController.coffee b/services/chat/app/coffee/Features/Messages/MessageHttpController.coffee index ce819e7b00..3574a2d0dc 100644 --- a/services/chat/app/coffee/Features/Messages/MessageHttpController.coffee +++ b/services/chat/app/coffee/Features/Messages/MessageHttpController.coffee @@ -60,7 +60,7 @@ module.exports = MessageHttpController = return next(error) if error? MessageManager.updateMessage room._id, message_id, content, Date.now(), (error) -> return next(error) if error? - res.send(200) + res.send(204) deleteMessage: (req, res, next) -> {project_id, thread_id, message_id} = req.params diff --git a/services/chat/app/coffee/Features/Messages/MessageManager.coffee b/services/chat/app/coffee/Features/Messages/MessageManager.coffee index a5a0fbd362..14a7142e68 100644 --- a/services/chat/app/coffee/Features/Messages/MessageManager.coffee +++ b/services/chat/app/coffee/Features/Messages/MessageManager.coffee @@ -43,9 +43,7 @@ module.exports = MessageManager = edited_at: timestamp }, (error) -> return callback(error) if error? - db.messages.find query, (error, messages) -> - return callback(error) if error? - return callback null, messages[0] + return callback() deleteMessage: (room_id, message_id, callback = (error) ->) -> query = @_ensureIdsAreObjectIds( diff --git a/services/chat/test/acceptance/coffee/EditingAMessageTests.coffee b/services/chat/test/acceptance/coffee/EditingAMessageTests.coffee index 0add6f3825..51e14cfedd 100644 --- a/services/chat/test/acceptance/coffee/EditingAMessageTests.coffee +++ b/services/chat/test/acceptance/coffee/EditingAMessageTests.coffee @@ -20,9 +20,7 @@ describe "Editing a message", -> expect(@message.content).to.equal @content ChatClient.editMessage @project_id, @thread_id, @message.id, @new_content, (error, response, @new_message) => expect(error).to.be.null - expect(response.statusCode).to.equal 201 - expect(@new_message.edited_at).to.exist - expect(@new_message.content).to.equal @new_content + expect(response.statusCode).to.equal 204 done() it "should then list the updated message in the threads", (done) ->