agw/overleaf-cep
1
0
Fork 0
mirror of https://github.com/yu-i-i/overleaf-cep.git synced 2026-06-01 05:11:34 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2974 from overleaf/jel-ns-user-projections-beta

Browse Source 
Remove user projections in BetaProgramHandler

GitOrigin-RevId: 88b7bc3b6f11ae9f8314543ee538c84d25cde7cd
This commit is contained in:
Miguel Serrano
2020-07-09 15:49:02 +02:00
committed by Copybot
parent 1cac5227d6
commit 8023e48efd
3 changed files with 103 additions and 132 deletions
Download Patch File Download Diff File Expand all files Collapse all files

112
services/web/test/unit/src/BetaProgram/BetaProgramHandlerTests.js
View File

@@ -1,19 +1,4 @@
/* eslint-disable
handle-callback-err,
max-len,
no-return-assign,
no-unused-vars,
*/
// TODO: This file was created by bulk-decaffeinate.
// Fix any style issues and re-enable lint.
/*
* decaffeinate suggestions:
* DS102: Remove unnecessary code created because of implicit returns
* Full docs: https://github.com/decaffeinate/decaffeinate/blob/master/docs/suggestions.md
*/
const should = require('chai').should()
const SandboxedModule = require('sandboxed-module')
const assert = require('assert')
const path = require('path')
const modulePath = path.join(
__dirname,
@@ -32,68 +17,56 @@ describe('BetaProgramHandler', function() {
betaProgram: false,
save: sinon.stub().callsArgWith(0, null)
}
return (this.handler = SandboxedModule.require(modulePath, {
this.handler = SandboxedModule.require(modulePath, {
globals: {
console: console
},
requires: {
'../../models/User': {
User: {
findById: sinon.stub().callsArgWith(1, null, this.user)
}
},
'logger-sharelatex': (this.logger = {
log: sinon.stub(),
warn: sinon.stub(),
err: sinon.stub()
}),
'metrics-sharelatex': (this.logger = {
inc: sinon.stub()
}),
'../User/UserUpdater': (this.UserUpdater = {
promises: {
updateUser: sinon.stub().resolves()
}
})
}
}))
})
})
describe('optIn', function() {
beforeEach(function() {
this.user.betaProgram = false
return (this.call = callback => {
return this.handler.optIn(this.user_id, callback)
})
this.call = callback => {
this.handler.optIn(this.user_id, callback)
}
})
it('should set betaProgram = true on user object', function(done) {
return this.call(err => {
this.user.betaProgram.should.equal(true)
return done()
})
})
it('should call user.save', function(done) {
return this.call(err => {
this.user.save.callCount.should.equal(1)
return done()
it('should call userUpdater', function(done) {
this.call(err => {
expect(err).to.not.exist
this.UserUpdater.promises.updateUser.callCount.should.equal(1)
done()
})
})
it('should not produce an error', function(done) {
return this.call(err => {
expect(err).to.equal(null)
expect(err).to.not.be.instanceof(Error)
return done()
this.call(err => {
expect(err).to.not.exist
done()
})
})
describe('when user.save produces an error', function() {
describe('when userUpdater produces an error', function() {
beforeEach(function() {
return this.user.save.callsArgWith(0, new Error('woops'))
this.UserUpdater.promises.updateUser.rejects()
})
it('should produce an error', function(done) {
return this.call(err => {
expect(err).to.not.equal(null)
this.call(err => {
expect(err).to.exist
expect(err).to.be.instanceof(Error)
return done()
done()
})
})
})
@@ -102,43 +75,36 @@ describe('BetaProgramHandler', function() {
describe('optOut', function() {
beforeEach(function() {
this.user.betaProgram = true
return (this.call = callback => {
return this.handler.optOut(this.user_id, callback)
})
this.call = callback => {
this.handler.optOut(this.user_id, callback)
}
})
it('should set betaProgram = true on user object', function(done) {
return this.call(err => {
this.user.betaProgram.should.equal(false)
return done()
})
})
it('should call user.save', function(done) {
return this.call(err => {
this.user.save.callCount.should.equal(1)
return done()
it('should call userUpdater', function(done) {
this.call(err => {
expect(err).to.not.exist
this.UserUpdater.promises.updateUser.callCount.should.equal(1)
done()
})
})
it('should not produce an error', function(done) {
return this.call(err => {
expect(err).to.equal(null)
expect(err).to.not.be.instanceof(Error)
return done()
this.call(err => {
expect(err).to.not.exist
done()
})
})
describe('when user.save produces an error', function() {
describe('when userUpdater produces an error', function() {
beforeEach(function() {
return this.user.save.callsArgWith(0, new Error('woops'))
this.UserUpdater.promises.updateUser.rejects()
})
it('should produce an error', function(done) {
return this.call(err => {
expect(err).to.not.equal(null)
this.call(err => {
expect(err).to.exist
expect(err).to.be.instanceof(Error)
return done()
done()
})
})
})