From 85547ffe40d4e866103dd45315d400a528bf9a8f Mon Sep 17 00:00:00 2001 From: Jakob Ackermann Date: Tue, 1 Nov 2022 10:49:02 +0000 Subject: [PATCH] Merge pull request #10234 from overleaf/jpa-pdf-caching-ignore-404 [web] pdf-caching: stop counting 404s on the output.pdf as failure GitOrigin-RevId: eb76570fdce3dd79b8e0ea961722e428446672ac --- .../js/features/pdf-preview/util/pdf-caching-transport.js | 2 -- 1 file changed, 2 deletions(-) diff --git a/services/web/frontend/js/features/pdf-preview/util/pdf-caching-transport.js b/services/web/frontend/js/features/pdf-preview/util/pdf-caching-transport.js index 356a85ffbb..3ca0fe0faf 100644 --- a/services/web/frontend/js/features/pdf-preview/util/pdf-caching-transport.js +++ b/services/web/frontend/js/features/pdf-preview/util/pdf-caching-transport.js @@ -83,8 +83,6 @@ export function generatePdfCachingTransportFactory(PDFJS) { OError.getFullInfo(err).url === this.url ) { // Do not consider a 404 on the main pdf url as pdf caching failure. - // Still, bail out during the initial launch phase. - metrics.failedOnce = true throw new PDFJS.MissingPDFException() } metrics.failedCount++