From 85ceab5310e7fce8650737862444e5e7535c6356 Mon Sep 17 00:00:00 2001 From: Alasdair Smith Date: Tue, 20 Feb 2018 16:25:30 +0000 Subject: [PATCH] Tear down Ace session when aceEditor is destroyed This cleans up the Ace worker that parses syntax, preventing a memory leak --- .../web/public/coffee/ide/editor/directives/aceEditor.coffee | 2 ++ 1 file changed, 2 insertions(+) diff --git a/services/web/public/coffee/ide/editor/directives/aceEditor.coffee b/services/web/public/coffee/ide/editor/directives/aceEditor.coffee index a128ecacb5..fd6a8224e4 100644 --- a/services/web/public/coffee/ide/editor/directives/aceEditor.coffee +++ b/services/web/public/coffee/ide/editor/directives/aceEditor.coffee @@ -430,6 +430,8 @@ define [ scope.$on '$destroy', () -> if scope.sharejsDoc? detachFromAce(scope.sharejsDoc) + session = editor.getSession() + session?.destroy() scope.$emit "#{scope.name}:inited", editor