agw/overleaf-cep
1
0
Fork 0
mirror of https://github.com/yu-i-i/overleaf-cep.git synced 2026-06-12 07:30:46 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #18225 from overleaf/em-typescript-eslint

Browse Source 
Add typescript-eslint rule: no-floating-promises

GitOrigin-RevId: 8c3decdff537c885f5bfeb5250b7805480bc6602
This commit is contained in:
Eric Mc Sween
2024-05-21 15:07:24 -04:00
committed by Copybot
parent 814b085b44
commit 876ee4d967
48 changed files with 1156 additions and 798 deletions
Download Patch File Download Diff File Expand all files Collapse all files
services/web/test/unit/src/Analytics/AnalyticsUTMTrackingMiddlewareTests.js
+7 -5
View File
@@ -29,7 +29,7 @@ describe('AnalyticsUTMTrackingMiddleware', function () {
requires: {
'./AnalyticsManager': (this.AnalyticsManager = {
recordEventForSession: sinon.stub().resolves(),
setUserPropertyForSession: sinon.stub().resolves(),
setUserPropertyForSessionInBackground: sinon.stub(),
}),
'@overleaf/settings': {
siteUrl: 'https://www.overleaf.com',
@@ -56,7 +56,9 @@ describe('AnalyticsUTMTrackingMiddleware', function () {
it('no event or user property is recorded', function () {
sinon.assert.notCalled(this.AnalyticsManager.recordEventForSession)
sinon.assert.notCalled(this.AnalyticsManager.setUserPropertyForSession)
sinon.assert.notCalled(
this.AnalyticsManager.setUserPropertyForSessionInBackground
)
})
})
@@ -101,7 +103,7 @@ describe('AnalyticsUTMTrackingMiddleware', function () {
it('utm-tags user property is set for session', function () {
sinon.assert.calledWith(
this.AnalyticsManager.setUserPropertyForSession,
this.AnalyticsManager.setUserPropertyForSessionInBackground,
this.req.session,
'utm-tags',
'Organic;Facebook;Some Campaign;foo-bar'
@@ -146,7 +148,7 @@ describe('AnalyticsUTMTrackingMiddleware', function () {
it('utm-tags user property is set for session', function () {
sinon.assert.calledWith(
this.AnalyticsManager.setUserPropertyForSession,
this.AnalyticsManager.setUserPropertyForSessionInBackground,
this.req.session,
'utm-tags',
'N/A;Facebook;Some Campaign;foo'
@@ -190,7 +192,7 @@ describe('AnalyticsUTMTrackingMiddleware', function () {
it('utm-tags user property is set for session', function () {
sinon.assert.calledWith(
this.AnalyticsManager.setUserPropertyForSession,
this.AnalyticsManager.setUserPropertyForSessionInBackground,
this.req.session,
'utm-tags',
'N/A;Facebook;Some Campaign;N/A'