From 87d1c08e2fc1d968c504e4e1b891b32f6cac61ca Mon Sep 17 00:00:00 2001 From: Alf Eaton Date: Wed, 10 Jul 2024 12:21:20 +0100 Subject: [PATCH] Merge pull request #19325 from overleaf/ae-metadata-packages Include all package names in the project metadata GitOrigin-RevId: dd30eb254806248484c9c6d9210f38c7c69a0ba1 --- .../web/app/src/Features/Metadata/MetaHandler.js | 1 + .../test/unit/src/Metadata/MetaHandlerTests.js | 16 ++++++++++++---- 2 files changed, 13 insertions(+), 4 deletions(-) diff --git a/services/web/app/src/Features/Metadata/MetaHandler.js b/services/web/app/src/Features/Metadata/MetaHandler.js index ce8f004788..009606fb3b 100644 --- a/services/web/app/src/Features/Metadata/MetaHandler.js +++ b/services/web/app/src/Features/Metadata/MetaHandler.js @@ -118,6 +118,7 @@ module.exports = MetaHandler = { docMeta.packages[pkg] = packageMapping[pkg] } } + docMeta.packageNames = packages return docMeta }, diff --git a/services/web/test/unit/src/Metadata/MetaHandlerTests.js b/services/web/test/unit/src/Metadata/MetaHandlerTests.js index c4514a4950..8c1f4bab8a 100644 --- a/services/web/test/unit/src/Metadata/MetaHandlerTests.js +++ b/services/web/test/unit/src/Metadata/MetaHandlerTests.js @@ -95,6 +95,7 @@ describe('MetaHandler', function () { }, ], }, + packageNames: ['foo', 'amsmath', 'booktabs'], }) }) }) @@ -138,9 +139,9 @@ describe('MetaHandler', function () { it('should extract all metadata', function () { const projectMeta = this.MetaHandler.extractMetaFromProjectDocs(this.docs) return expect(projectMeta).to.deep.equal({ - id_one: { labels: ['aaa'], packages: {} }, - id_two: { labels: [], packages: {} }, - id_three: { labels: ['bbb', 'ccc'], packages: {} }, + id_one: { labels: ['aaa'], packages: {}, packageNames: [] }, + id_two: { labels: [], packages: {}, packageNames: [] }, + id_three: { labels: ['bbb', 'ccc'], packages: {}, packageNames: [] }, id_four: { labels: [], packages: { @@ -153,6 +154,7 @@ describe('MetaHandler', function () { }, ], }, + packageNames: ['baz', 'amsmath'], }, id_five: { labels: ['sec:intro'], @@ -180,6 +182,7 @@ describe('MetaHandler', function () { }, ], }, + packageNames: ['foo', 'baz', 'hello'], }, }) }) @@ -195,7 +198,11 @@ describe('MetaHandler', function () { // bbb should not be in the returned labels 'commented label % \\label{bbb}', ] - this.fakeMeta = { labels: ['aaa'], packages: ['abc'] } + this.fakeMeta = { + labels: ['aaa'], + packages: { abc: [] }, + packageNames: ['abc'], + } this.DocumentUpdaterHandler.flushDocToMongo = sinon .stub() .callsArgWith(2, null) @@ -283,6 +290,7 @@ describe('MetaHandler', function () { }, ], }, + packageNames: ['foo'], } this.DocumentUpdaterHandler.flushProjectToMongo = sinon .stub()