From 8aed8f7dd7c509038f1e42aa3b6baed8d54151f4 Mon Sep 17 00:00:00 2001 From: M Fahru Date: Tue, 21 Nov 2023 11:30:19 -0700 Subject: [PATCH] Merge pull request #15857 from overleaf/mf-split-test-website-redesign [web] Configure `website-redesign` split test GitOrigin-RevId: 8b1b3c6ab1ba9c674517ebdb87e89bd3a44aade7 --- .../Features/StaticPages/HomeController.js | 24 ++++++++++++++----- .../app/src/infrastructure/ExpressLocals.js | 5 +++- 2 files changed, 22 insertions(+), 7 deletions(-) diff --git a/services/web/app/src/Features/StaticPages/HomeController.js b/services/web/app/src/Features/StaticPages/HomeController.js index f2b9585cd8..b35369852e 100644 --- a/services/web/app/src/Features/StaticPages/HomeController.js +++ b/services/web/app/src/Features/StaticPages/HomeController.js @@ -58,6 +58,12 @@ module.exports = HomeController = { ) } + const websiteRedesignVariant = + res.locals.splitTestVariants?.['website-redesign'] + const websiteRedesignActive = + websiteRedesignVariant === 'new-design' || + websiteRedesignVariant === 'new-design-registration' + const onboardingFlowAssignment = await SplitTestHandler.promises.getAssignment( req, @@ -65,12 +71,18 @@ module.exports = HomeController = { 'onboarding-flow' ) - return res.render('external/home/v2', { - designSystemUpdatesVariant: designSystemUpdatesAssignment.variant, - onboardingFlowVariant: onboardingFlowAssignment.variant, - hideNewsletterCheckbox: - onboardingFlowAssignment.variant === 'token-confirmation-odc', - }) + if (websiteRedesignActive) { + return res.render('external/home/website-redesign/index', { + onboardingFlowVariant: onboardingFlowAssignment.variant, + }) + } else { + return res.render('external/home/v2', { + designSystemUpdatesVariant: designSystemUpdatesAssignment.variant, + onboardingFlowVariant: onboardingFlowAssignment.variant, + hideNewsletterCheckbox: + onboardingFlowAssignment.variant === 'token-confirmation-odc', + }) + } } else { return res.redirect('/login') } diff --git a/services/web/app/src/infrastructure/ExpressLocals.js b/services/web/app/src/infrastructure/ExpressLocals.js index 310b12f825..55c9951685 100644 --- a/services/web/app/src/infrastructure/ExpressLocals.js +++ b/services/web/app/src/infrastructure/ExpressLocals.js @@ -81,7 +81,10 @@ function getWebpackAssets(entrypoint, section) { module.exports = function (webRouter, privateApiRouter, publicApiRouter) { webRouter.use( expressify( - SplitTestMiddleware.loadAssignmentsInLocals(['design-system-updates']) + SplitTestMiddleware.loadAssignmentsInLocals([ + 'design-system-updates', + 'website-redesign', + ]) ) )