From 8b1a0291a30c7ce0417fe4cd79da66a12dbbf5a3 Mon Sep 17 00:00:00 2001 From: M Fahru Date: Thu, 29 Sep 2022 05:53:47 -0700 Subject: [PATCH] Fix event segmentations for some of the plans-page-click events on the new plans page (#9781) * change event segmentation to plans-page-layout-v2-annual * update some new plans page event to have new event key * add location segmentation key for some of the group plans events GitOrigin-RevId: 99d8258112d9661955a196e57ca05a017afba0f4 --- .../app/src/Features/Subscription/plansV2Config.js | 12 +++++++++--- .../subscriptions/plans-marketing/v2/_mixins.pug | 3 +++ .../web/frontend/js/pages/user/subscription/plans.js | 2 +- 3 files changed, 13 insertions(+), 4 deletions(-) diff --git a/services/web/app/src/Features/Subscription/plansV2Config.js b/services/web/app/src/Features/Subscription/plansV2Config.js index a1cd57f09a..dab97f783b 100644 --- a/services/web/app/src/Features/Subscription/plansV2Config.js +++ b/services/web/app/src/Features/Subscription/plansV2Config.js @@ -17,7 +17,9 @@ const config = { }, }, eventTrackingKey: 'plans-page-click', - additionalEventSegmentation: { 'plan-page-layout-v2': 'new-plans-page' }, + additionalEventSegmentation: { + 'plans-page-layout-v2-annual': 'new-plans-page', + }, }, group: { tableHead: { @@ -33,7 +35,9 @@ const config = { }, }, eventTrackingKey: 'plans-page-click', - additionalEventSegmentation: { 'plan-page-layout-v2': 'new-plans-page' }, + additionalEventSegmentation: { + 'plans-page-layout-v2-annual': 'new-plans-page', + }, }, student: { baseColspan: 2, @@ -56,7 +60,9 @@ const config = { }, }, eventTrackingKey: 'plans-page-click', - additionalEventSegmentation: { 'plan-page-layout-v2': 'new-plans-page' }, + additionalEventSegmentation: { + 'plans-page-layout-v2-annual': 'new-plans-page', + }, }, } diff --git a/services/web/app/views/subscriptions/plans-marketing/v2/_mixins.pug b/services/web/app/views/subscriptions/plans-marketing/v2/_mixins.pug index e951b8e0d5..1047007be6 100644 --- a/services/web/app/views/subscriptions/plans-marketing/v2/_mixins.pug +++ b/services/web/app/views/subscriptions/plans-marketing/v2/_mixins.pug @@ -429,6 +429,7 @@ mixin btn_buy_group_collaborator(highlighted, eventTrackingKey) data-ol-event-tracking-key=eventTrackingKey data-ol-item-view='annual' data-ol-has-custom-href + data-ol-location='table-header' class=(highlighted ? 'btn-primary' : 'btn-default') ) span #{translate("customize")} @@ -440,6 +441,7 @@ mixin btn_buy_group_professional(highlighted, eventTrackingKey) data-ol-event-tracking-key=eventTrackingKey data-ol-item-view='annual' data-ol-has-custom-href + data-ol-location='table-header' class=(highlighted ? 'btn-primary' : 'btn-default') ) span #{translate("customize")} @@ -451,6 +453,7 @@ mixin btn_buy_group_organization(highlighted, eventTrackingKey) data-ol-event-tracking-key=eventTrackingKey data-ol-item-view='annual' data-ol-has-custom-href + data-ol-location='table-header' href='/for/contact-sales' target='_blank' class=(highlighted ? 'btn-primary' : 'btn-default') diff --git a/services/web/frontend/js/pages/user/subscription/plans.js b/services/web/frontend/js/pages/user/subscription/plans.js index 3e20aa33cd..db71617e12 100644 --- a/services/web/frontend/js/pages/user/subscription/plans.js +++ b/services/web/frontend/js/pages/user/subscription/plans.js @@ -72,7 +72,7 @@ function setUpSubscriptionTracking(linkEl) { } if (eventTrackingKey === DEFAULT_EVENT_TRACKING_KEY) { - eventTrackingSegmentation.PLANS_PAGE_LAYOUT_V2_ANNUAL = + eventTrackingSegmentation[PLANS_PAGE_LAYOUT_V2_ANNUAL] = plansPageV2SplitTestVariant }