Add markdown link tooltip support to the visual editor

GitOrigin-RevId: 7ab4fd0793f057c86e4fc0307d81df376efe4d34
This commit is contained in:
Domagoj Kriskovic
2026-06-16 08:05:46 +00:00
committed by Copybot
parent 93a4f0c88a
commit 8ccdc0fbc4
2 changed files with 51 additions and 8 deletions
@@ -11,11 +11,13 @@ import {
import {
EditorSelection,
EditorState,
Facet,
Prec,
SelectionRange,
StateEffect,
StateField,
} from '@codemirror/state'
import type { ReactNode } from 'react'
import { ancestorOfNodeWithType } from '../utils/tree-query'
import { ensureSyntaxTree, syntaxTree } from '@codemirror/language'
import {
@@ -32,12 +34,30 @@ import {
} from '@codemirror/autocomplete'
import { SyntaxNode } from '@lezer/common'
type ActiveTooltip = {
export type ActiveTooltip = {
range: SelectionRange
tooltip: Tooltip
command: string
} | null
export type CommandTooltipContext = {
state: EditorState
pos: number
value: ActiveTooltip
commandNode: SyntaxNode
}
// A command-tooltip handler lets a module add a tooltip for a syntax node type
// that isn't part of the LaTeX `$CommandTooltipCommand` group (e.g. the
// markdown `Link` node)
export type CommandTooltipHandler = {
command: string
createTooltip: (context: CommandTooltipContext) => ActiveTooltip
render: () => ReactNode
}
export const commandTooltipHandlers = Facet.define<CommandTooltipHandler>()
const createTooltipView = (
update?: (update: ViewUpdate) => void
): TooltipView => {
@@ -47,7 +67,7 @@ const createTooltipView = (
return { dom, update }
}
const buildTooltip = (
export const buildTooltip = (
command: string,
pos: number,
value: ActiveTooltip,
@@ -89,7 +109,12 @@ const createTooltipState = (
const { main } = state.selection
const pos = main.head
const node = syntaxTree(state).resolveInner(pos, 0)
const commandNode = ancestorOfNodeWithType(node, '$CommandTooltipCommand')
const moduleHandlers = state.facet(commandTooltipHandlers)
const commandNode = ancestorOfNodeWithType(
node,
'$CommandTooltipCommand',
...moduleHandlers.map(handler => handler.command)
)
if (!commandNode) {
return null
}
@@ -99,6 +124,15 @@ const createTooltipState = (
}
const commandName = commandNode.name
// Module-provided handlers (e.g. the markdown link tooltip) take priority
// over the built-in LaTeX commands below.
const handler = moduleHandlers.find(
handler => handler.command === commandName
)
if (handler) {
return handler.createTooltip({ state, pos, value, commandNode })
}
switch (commandName) {
// a hyperlink (\href)
case 'HrefCommand': {
@@ -317,7 +351,7 @@ export const commandTooltipState = (
state: EditorState
): ActiveTooltip | undefined => state.field(commandTooltipStateField, false)
const firstInteractiveElement = (
export const firstInteractiveElement = (
view: EditorView,
tooltipState: NonNullable<ActiveTooltip>
) =>