From 8d808d8f7b7fc96f31fb46492a1323b190ef8c8b Mon Sep 17 00:00:00 2001 From: Jakob Ackermann Date: Mon, 21 Jul 2025 16:05:11 +0200 Subject: [PATCH] [third-party-datastore] improve error handling (#26881) * [third-party-datastore] use generic serializer for dropboxError The `err` serializer will not pick up all the dropbox fields. Co-authored-by: Thomas Mees * [third-party-datastore] handle user_suspended like insufficient_space Unlink dropbox and display a notification (same key to clear later). Co-authored-by: Thomas Mees * [third-party-datastore] skip retries when rejected with disallowed_name Co-authored-by: Thomas Mees * [web] sort translations * [web] update copy for dropbox_unlinked_because_suspended Co-authored-by: Kamal Arkinstall --------- Co-authored-by: Thomas Mees Co-authored-by: Kamal Arkinstall GitOrigin-RevId: 8fbb9074d1d6eb879e904d79dd4b2a2c952ff902 --- services/web/locales/en.json | 1 + services/web/scripts/translations/cleanupUnusedLocales.js | 1 + 2 files changed, 2 insertions(+) diff --git a/services/web/locales/en.json b/services/web/locales/en.json index 4df2e389cd..7254f4d809 100644 --- a/services/web/locales/en.json +++ b/services/web/locales/en.json @@ -615,6 +615,7 @@ "dropbox_synced": "Overleaf and Dropbox have processed all updates. Note that your local Dropbox might still be synchronizing", "dropbox_unlinked_because_access_denied": "Your Dropbox account has been unlinked because the Dropbox service rejected your stored credentials. Please relink your Dropbox account to continue using it with Overleaf.", "dropbox_unlinked_because_full": "Your Dropbox account has been unlinked because it is full, and we can no longer send updates to it. Please free up some space and relink your Dropbox account to continue using it with Overleaf.", + "dropbox_unlinked_because_suspended": "We’ve unlinked your Dropbox account because it’s been suspended by Dropbox. You’ll be able to relink once you’ve resolved the issue with Dropbox.", "dropbox_unlinked_premium_feature": "<0>Your Dropbox account has been unlinked because Dropbox Sync is a premium feature that you had through an institutional license.", "due_date": "Due __date__", "due_today": "Due today", diff --git a/services/web/scripts/translations/cleanupUnusedLocales.js b/services/web/scripts/translations/cleanupUnusedLocales.js index e3d4d85435..d98ee6eb7e 100644 --- a/services/web/scripts/translations/cleanupUnusedLocales.js +++ b/services/web/scripts/translations/cleanupUnusedLocales.js @@ -74,6 +74,7 @@ async function main() { 'dropbox_email_not_verified', 'dropbox_unlinked_because_access_denied', 'dropbox_unlinked_because_full', + 'dropbox_unlinked_because_suspended', // Actually used without the spurious space. // TODO: fix the space and upload the changed locales