Merge pull request #34357 from overleaf/mg-combine-floating-menus

Add combined floating menu for comment, tracked changes, writefull

GitOrigin-RevId: 4de5b9d3b1717fc76394f7c0edfe4d7230394c8d
This commit is contained in:
Malik Glossop
2026-06-17 08:06:44 +00:00
committed by Copybot
parent 9fae908602
commit 8ef463f8b0
11 changed files with 685 additions and 2 deletions
@@ -13,6 +13,8 @@ import { ReviewPanelProviders } from '@/features/review-panel/context/review-pan
import { ReviewPanelRoot } from '@/features/review-panel/components/review-panel-root'
import ReviewPanelTabsHeaderPortal from '@/features/review-panel/components/review-panel-tabs-header-portal'
import ReviewTooltipMenu from '@/features/review-panel/components/review-tooltip-menu'
import EditorFloatingMenu from '@/features/editor-floating-menu/editor-floating-menu'
import AddCommentCommand from '@/features/editor-floating-menu/components/add-comment-command'
import {
CodeMirrorStateContext,
CodeMirrorViewContext,
@@ -93,6 +95,9 @@ function CodeMirrorEditorComponents({
}: CodeMirrorEditorComponentsProps) {
useToolbarMenuBarEditorCommands()
const { features } = useProjectContext()
const writefullToolbarMigrationEnabled = useFeatureFlag(
'writefull-toolbar-migration'
)
return (
<ReviewPanelProviders>
<CodemirrorOutline />
@@ -104,7 +109,15 @@ function CodeMirrorEditorComponents({
<MathPreviewTooltip />
<EditorContextMenu />
{features.trackChangesVisible && <ReviewTooltipMenu />}
{features.trackChangesVisible &&
(writefullToolbarMigrationEnabled ? (
<>
<AddCommentCommand />
<EditorFloatingMenu />
</>
) : (
<ReviewTooltipMenu />
))}
{features.trackChangesVisible && <ReviewPanelTabsHeaderPortal />}
{features.trackChangesVisible && <ReviewPanelRoot />}
{features.trackChangesVisible && <UpgradeTrackChangesModal />}