agw/overleaf-cep
1
0
Fork 0
mirror of https://github.com/yu-i-i/overleaf-cep.git synced 2026-11-12 21:23:45 +01:00
Code Issues Packages Projects Releases Wiki Activity

Add a "unsignedUrls" option to the GCS persistor

Browse Source 
This boolean option disables URL signing. Instead, getRedirectUrl()
returns the plain GCS download URL.
This commit is contained in:
Eric Mc Sween
2020-09-22 15:59:13 -04:00
parent 2574b16116
commit 9089d332ab
3 changed files with 35 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
libraries/object-persistor/test/unit/GcsPersistorTests.js
+26 -7
View File
@@ -260,16 +260,35 @@ describe('GcsPersistorTests', function () {
describe('getRedirectUrl', function () {
let signedUrl
beforeEach(async function () {
signedUrl = await GcsPersistor.getRedirectUrl(bucket, key)
describe('with signed URLs', function () {
beforeEach(async function () {
signedUrl = await GcsPersistor.getRedirectUrl(bucket, key)
})
it('should request a signed URL', function () {
expect(GcsFile.getSignedUrl).to.have.been.called
})
it('should return the url', function () {
expect(signedUrl).to.equal(redirectUrl)
})
})
it('should request a signed URL', function () {
expect(GcsFile.getSignedUrl).to.have.been.called
})
describe('with unsigned URLs', function () {
beforeEach(async function () {
GcsPersistor.settings.unsignedUrls = true
GcsPersistor.settings.endpoint = {
apiScheme: 'http',
apiEndpoint: 'custom.endpoint'
}
signedUrl = await GcsPersistor.getRedirectUrl(bucket, key)
})
it('should return the url', function () {
expect(signedUrl).to.equal(redirectUrl)
it('should return a plain URL', function () {
expect(signedUrl).to.equal(
`http://custom.endpoint/download/storage/v1/b/${bucket}/o/${key}?alt=media`
)
})
})
})