agw/overleaf-cep
1
0
Fork 0
mirror of https://github.com/yu-i-i/overleaf-cep.git synced 2026-11-15 14:43:46 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #12121 from overleaf/bg-fix-bad-offsets-in-history-migration

Browse Source 
fix out of range offsets to avoid invalid history exports

GitOrigin-RevId: d00e3e9e08feb6c3be671b5805102a66782b3f92
This commit is contained in:
Brian Gough
2023-03-08 09:04:00 +00:00
committed by Copybot
parent 1f2c06b1d0
commit 9276ba87b2
3 changed files with 34 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
services/track-changes/app/js/DiffGenerator.js
+4
View File
@@ -63,6 +63,7 @@ module.exports = DiffGenerator = {
if (p > max_p) {
logger.warn({ max_p, p }, 'truncating position to content length')
p = max_p
op.p = p // fix out of range offsets to avoid invalid history exports in ZipManager
}
const textToBeRemoved = content.slice(p, p + op.i.length)
@@ -74,6 +75,9 @@ module.exports = DiffGenerator = {
return content.slice(0, p) + content.slice(p + op.i.length)
} else if (op.d != null) {
if (op.p > content.length) {
op.p = content.length // fix out of range offsets to avoid invalid history exports in ZipManager
}
return content.slice(0, op.p) + op.d + content.slice(op.p)
} else {
return content