From 9386ddf4a9a5f14f9c3147813f54ad70a77aa1f7 Mon Sep 17 00:00:00 2001 From: Alasdair Smith Date: Wed, 27 Sep 2017 17:08:58 +0100 Subject: [PATCH] Only show autocompile onboarding when first manual compile is run --- services/web/app/views/project/editor/editor.pug | 6 +++++- services/web/public/coffee/ide.coffee | 3 +++ .../public/coffee/ide/pdf/controllers/PdfController.coffee | 3 +++ 3 files changed, 11 insertions(+), 1 deletion(-) diff --git a/services/web/app/views/project/editor/editor.pug b/services/web/app/views/project/editor/editor.pug index c68b889d6d..daac701f31 100644 --- a/services/web/app/views/project/editor/editor.pug +++ b/services/web/app/views/project/editor/editor.pug @@ -95,7 +95,11 @@ div.full-size( ) include ./pdf -.onboarding__autocompile.popover.right(ng-controller="AutoCompileOnboardingController") + +.popover.right.onboarding__autocompile( + ng-controller="AutoCompileOnboardingController" + ng-if="onboarding.autoCompile == 'show'" +) .arrow .popover-inner h3.popover-title Auto Compile diff --git a/services/web/public/coffee/ide.coffee b/services/web/public/coffee/ide.coffee index 5fc208ce87..6e4061081c 100644 --- a/services/web/public/coffee/ide.coffee +++ b/services/web/public/coffee/ide.coffee @@ -77,6 +77,9 @@ define [ miniReviewPanelVisible: false, showAutoCompileOnboarding: window.user.betaProgram and window.showAutoCompileOnboarding } + $scope.onboarding = { + autoCompile: 'unseen' + } $scope.user = window.user $scope.$watch "project.features.trackChangesVisible", (visible) -> diff --git a/services/web/public/coffee/ide/pdf/controllers/PdfController.coffee b/services/web/public/coffee/ide/pdf/controllers/PdfController.coffee index 73ae9a4380..1e0403bb76 100644 --- a/services/web/public/coffee/ide/pdf/controllers/PdfController.coffee +++ b/services/web/public/coffee/ide/pdf/controllers/PdfController.coffee @@ -412,6 +412,9 @@ define [ $scope.recompile = (options = {}) -> return if $scope.pdf.compiling + if !options.isAutoCompile and $scope.onboarding.autoCompile == 'unseen' + $scope.onboarding.autoCompile = 'show' + event_tracking.sendMBSampled "editor-recompile-sampled", options $scope.pdf.compiling = true