From 991d3c7aa1308fb1ee9e641a9f42b02332894878 Mon Sep 17 00:00:00 2001 From: Brian Gough Date: Tue, 14 Jun 2016 12:49:06 +0100 Subject: [PATCH] avoid exception when switching between full and split pdf view --- .../coffee/ide/pdfng/directives/pdfViewer.coffee | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/services/web/public/coffee/ide/pdfng/directives/pdfViewer.coffee b/services/web/public/coffee/ide/pdfng/directives/pdfViewer.coffee index b719dfb0f2..5f87ff25e9 100644 --- a/services/web/public/coffee/ide/pdfng/directives/pdfViewer.coffee +++ b/services/web/public/coffee/ide/pdfng/directives/pdfViewer.coffee @@ -516,7 +516,15 @@ define [ first = highlights[0] - pageNum = scope.pages[first.page].pageNum + # switching between split and full pdf views can cause + # highlights to appear before rendering + if !scope.pages + return # ignore highlight scroll if still rendering + + pageNum = scope.pages[first.page]?.pageNum + + if !pageNum? + return # ignore highlight scroll if page not found # use a visual offset of 72pt to match the offset in PdfController syncToCode scope.document.getPdfViewport(pageNum).then (viewport) ->