agw/overleaf-cep
1
0
Fork 0
mirror of https://github.com/yu-i-i/overleaf-cep.git synced 2026-11-14 14:13:43 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #35435 from overleaf/em-library-stop-main-cluster-writes

Browse Source 
Stop writes to the main Mongo cluster for library collections

GitOrigin-RevId: 39c9ccc2a02e291befcf197fa806ee5aab900a8d
This commit is contained in:
Eric Mc Sween
2026-09-17 11:27:53 +00:00
committed by Copybot
parent 61ef838424
commit 9b79ccea5b
2 changed files with 17 additions and 173 deletions
Download Patch File Download Diff File Expand all files Collapse all files
services/web/test/unit/src/infrastructure/Mongodb.test.mjs
+7 -45
View File
@@ -1,7 +1,6 @@
import mongodb from 'mongodb-legacy'
import { beforeEach, describe, expect, it, vi } from 'vitest'
import sinon from 'sinon'
import logger from '@overleaf/logger'
const { ObjectId } = mongodb
@@ -255,62 +254,25 @@ describe('auxiliary cluster support', function () {
expect(clients.map(c => c.url)).to.include.members([MAIN_URL, AUX_URL])
})
it('writes authoritatively to the auxiliary collection, mirrors to the main collection, and returns the auxiliary result', async function () {
it('exposes the plain auxiliary-cluster collection, unwrapped', async function () {
const { db } = await loadModule(AUX_URL)
const mainCollection = collectionsByUrl[MAIN_URL].get('libraryReferences')
const auxCollection = collectionsByUrl[AUX_URL].get('libraryReferences')
mainCollection.insertMany.resolves({ from: 'main' })
auxCollection.insertMany.resolves({ from: 'aux' })
const result = await db.libraryReferences.insertMany([{ _id: 1 }], {
ordered: false,
})
expect(result).to.deep.equal({ from: 'aux' })
expect(auxCollection.insertMany).to.have.been.calledWith([{ _id: 1 }], {
ordered: false,
})
expect(mainCollection.insertMany).to.have.been.calledWith([{ _id: 1 }], {
ordered: false,
})
expect(db.libraryReferences).to.equal(auxCollection)
})
it('only reads from the auxiliary collection', async function () {
it('only reads and writes to the auxiliary collection', async function () {
const { db } = await loadModule(AUX_URL)
await db.libraryReferences.find({ userId: 'abc' })
await db.libraryReferences.insertMany([{ _id: 1 }], { ordered: false })
const mainCollection = collectionsByUrl[MAIN_URL].get('libraryReferences')
const auxCollection = collectionsByUrl[AUX_URL].get('libraryReferences')
expect(auxCollection.find).to.have.been.calledWith({
userId: 'abc',
})
expect(mainCollection.find).to.not.have.been.called
})
it('swallows main cluster write failures without affecting the auxiliary result', async function () {
const { db } = await loadModule(AUX_URL)
const mainCollection = collectionsByUrl[MAIN_URL].get('librarySizes')
mainCollection.updateOne.rejects(new Error('main cluster write failed'))
const result = await db.librarySizes.updateOne(
{ _id: 'user1' },
{ $set: { size: 1 } }
)
expect(result).to.deep.equal({ ok: true })
await vi.waitFor(() => {
expect(logger.warn).toHaveBeenCalled()
expect(auxCollection.insertMany).to.have.been.calledWith([{ _id: 1 }], {
ordered: false,
})
})
it('does not swallow auxiliary write failures, since it is the authoritative write', async function () {
const { db } = await loadModule(AUX_URL)
const auxCollection = collectionsByUrl[AUX_URL].get('librarySizes')
auxCollection.updateOne.rejects(new Error('auxiliary write failed'))
await expect(
db.librarySizes.updateOne({ _id: 'user1' }, { $set: { size: 1 } })
).to.eventually.be.rejectedWith('auxiliary write failed')
expect(collectionsByUrl[MAIN_URL].has('libraryReferences')).to.be.false
})
it('waits for both the main and auxiliary connections', async function () {