agw/overleaf-cep
1
0
Fork 0
mirror of https://github.com/yu-i-i/overleaf-cep.git synced 2026-06-02 21:59:00 +02:00
Code Issues Packages Projects Releases Wiki Activity

Delay Dropbox polling by 5 seconds and dispatch only a single request

Browse Source
This commit is contained in:
James Allen
2014-08-14 13:48:23 +01:00
parent 7816810249
commit 9be7228247
3 changed files with 98 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files
services/web/test/UnitTests/coffee/Dropbox/DropboxWebhookHandlerTests.coffee
+59 -11
View File
@@ -1,6 +1,7 @@
SandboxedModule = require('sandboxed-module')
assert = require('assert')
require('chai').should()
expect = require("chai").expect
sinon = require('sinon')
modulePath = require('path').join __dirname, '../../../../app/js/Features/Dropbox/DropboxWebhookHandler.js'
@@ -9,6 +10,10 @@ describe 'DropboxWebhookHandler', ->
@DropboxWebhookHandler = SandboxedModule.require modulePath, requires:
"../../models/User": User: @User = {}
"../ThirdPartyDataStore/TpdsUpdateSender": @TpdsUpdateSender = {}
"redis":
createClient: () => @rclient =
auth: sinon.stub()
'settings-sharelatex': redis: web: {}
'logger-sharelatex':
log:->
err:->
@@ -35,17 +40,60 @@ describe 'DropboxWebhookHandler', ->
@user_id = "sharelatex-user-id"
@User.find = sinon.stub().callsArgWith(1, null, [ _id: @user_id ])
@TpdsUpdateSender.pollDropboxForUser = sinon.stub().callsArg(1)
@DropboxWebhookHandler.pollDropboxUid @dropbox_uid, @callback
it "should look up the user", ->
@User.find
.calledWith({ "dropbox.access_token.uid": @dropbox_uid, "features.dropbox": true })
.should.equal true
describe "when there is already a poll in progress", () ->
beforeEach ->
@DropboxWebhookHandler._delayAndBatchPoll = sinon.stub().callsArgWith(1, null, false)
@DropboxWebhookHandler.pollDropboxUid @dropbox_uid, @callback
it "should poll the user's Dropbox", ->
@TpdsUpdateSender.pollDropboxForUser
.calledWith(@user_id)
.should.equal true
it "should not go ahead with the poll", ->
@TpdsUpdateSender.pollDropboxForUser.called.should.equal false
describe "when we are the one to do the delayed poll", () ->
beforeEach ->
@DropboxWebhookHandler._delayAndBatchPoll = sinon.stub().callsArgWith(1, null, true)
@DropboxWebhookHandler.pollDropboxUid @dropbox_uid, @callback
it "should look up the user", ->
@User.find
.calledWith({ "dropbox.access_token.uid": @dropbox_uid, "features.dropbox": true })
.should.equal true
it "should poll the user's Dropbox", ->
@TpdsUpdateSender.pollDropboxForUser
.calledWith(@user_id)
.should.equal true
it "should call the callback", ->
@callback.called.should.equal true
describe "_delayAndBatchPoll", () ->
beforeEach ->
@dropbox_uid = "dropbox-uid-123"
@DropboxWebhookHandler.POLL_DELAY_IN_MS = 100
describe "when no one else is polling yet", ->
beforeEach (done) ->
@rclient.set = sinon.stub().callsArgWith(5, null, "OK")
@start = Date.now()
@DropboxWebhookHandler._delayAndBatchPoll @dropbox_uid, (error, @shouldPoll) =>
@end = Date.now()
done()
it "should set the lock", ->
@rclient.set
.calledWith("dropbox-poll-lock:#{@dropbox_uid}", "LOCK", "PX", @DropboxWebhookHandler.POLL_DELAY_IN_MS, "NX")
.should.equal true
it "should return the callback after the delay with shouldPoll=true", ->
@shouldPoll.should.equal true
expect(@end - @start).to.be.at.least(@DropboxWebhookHandler.POLL_DELAY_IN_MS)
describe "when someone else is already polling", ->
beforeEach ->
@rclient.set = sinon.stub().callsArgWith(5, null, null)
@DropboxWebhookHandler._delayAndBatchPoll @dropbox_uid, @callback
it "should return the callback immediately with shouldPoll=false", ->
@callback.calledWith(null, false).should.equal true
it "should call the callback", ->
@callback.called.should.equal true