From 9cf284aefa2e91a4d7fafc3792beb813f696cb59 Mon Sep 17 00:00:00 2001 From: Brian Gough Date: Thu, 8 May 2025 15:32:36 +0100 Subject: [PATCH] Merge pull request #25414 from overleaf/bg-history-only-log-content-mismatch-once-per-request log warning for content hash mismatch only on first occurrence GitOrigin-RevId: ff09f8c262461488bd564ea0644d414bb32ff17e --- services/history-v1/storage/lib/persist_changes.js | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/services/history-v1/storage/lib/persist_changes.js b/services/history-v1/storage/lib/persist_changes.js index 47798531b2..07ac100790 100644 --- a/services/history-v1/storage/lib/persist_changes.js +++ b/services/history-v1/storage/lib/persist_changes.js @@ -167,10 +167,13 @@ async function persistChanges(projectId, allChanges, limits, clientEndVersion) { const actualHash = content != null ? getContentHash(content) : null logger.debug({ expectedHash, actualHash }, 'validating content hash') if (actualHash !== expectedHash) { - logger.warn( - { projectId, path, expectedHash, actualHash }, - 'content hash mismatch' - ) + // only log a warning on the first mismatch in each persistChanges call + if (!resyncNeeded) { + logger.warn( + { projectId, path, expectedHash, actualHash }, + 'content hash mismatch' + ) + } resyncNeeded = true }