Merge pull request #3830 from overleaf/em-upgrade-node-12

Upgrade to Node 12

GitOrigin-RevId: 19870922884b7c98e7e5f2c94df21829672d2db5

services/web/test/unit/src/BetaProgram/BetaProgramControllerTests.js

@@ -1,4 +1,3 @@
-require('chai').should()
 const SandboxedModule = require('sandboxed-module')
 const path = require('path')
 const sinon = require('sinon')
@@ -23,9 +22,6 @@ describe('BetaProgramController', function() {
       }
     }
     this.BetaProgramController = SandboxedModule.require(modulePath, {
-      globals: {
-        console: console
-      },
       requires: {
         './BetaProgramHandler': (this.BetaProgramHandler = {
           optIn: sinon.stub(),
@@ -37,12 +33,6 @@ describe('BetaProgramController', function() {
         'settings-sharelatex': (this.settings = {
           languages: {}
         }),
-        'logger-sharelatex': (this.logger = {
-          log: sinon.stub(),
-          warn: sinon.stub(),
-          err: sinon.stub(),
-          error: sinon.stub()
-        }),
         '../Authentication/AuthenticationController': (this.AuthenticationController = {
           getLoggedInUserId: sinon.stub().returns(this.user._id)
         })

services/web/test/unit/src/BetaProgram/BetaProgramHandlerTests.js

@@ -18,13 +18,10 @@ describe('BetaProgramHandler', function() {
       save: sinon.stub().callsArgWith(0, null)
     }
     this.handler = SandboxedModule.require(modulePath, {
-      globals: {
-        console: console
-      },
       requires: {
-        '@overleaf/metrics': (this.logger = {
+        '@overleaf/metrics': {
           inc: sinon.stub()
-        }),
+        },
         '../User/UserUpdater': (this.UserUpdater = {
           promises: {
             updateUser: sinon.stub().resolves()