From a0dd439e2cbe2a3e83335bde2b02ec6994761e91 Mon Sep 17 00:00:00 2001 From: Alexandre Bourdin Date: Thu, 24 Jun 2021 11:34:26 +0200 Subject: [PATCH] Merge pull request #4256 from overleaf/ab-analytics-manager-nullcheck-userid Add null checks on userId to all AnalyticsManager functions GitOrigin-RevId: ca4d50c9309aadf0145fd5135bbdecb7d297ea6f --- .../app/src/Features/Analytics/AnalyticsManager.js | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/services/web/app/src/Features/Analytics/AnalyticsManager.js b/services/web/app/src/Features/Analytics/AnalyticsManager.js index c55bb6a769..5a3e33051c 100644 --- a/services/web/app/src/Features/Analytics/AnalyticsManager.js +++ b/services/web/app/src/Features/Analytics/AnalyticsManager.js @@ -7,6 +7,9 @@ const analyticsEditingSessionsQueue = Queues.getAnalyticsEditingSessionsQueue() const analyticsUserPropertiesQueue = Queues.getAnalyticsUserPropertiesQueue() function identifyUser(userId, oldUserId) { + if (!userId || !oldUserId) { + return + } if (isAnalyticsDisabled() || isSmokeTestUser(userId)) { return } @@ -22,6 +25,9 @@ function identifyUser(userId, oldUserId) { } function recordEvent(userId, event, segmentation) { + if (!userId) { + return + } if (isAnalyticsDisabled() || isSmokeTestUser(userId)) { return } @@ -37,6 +43,9 @@ function recordEvent(userId, event, segmentation) { } function updateEditingSession(userId, projectId, countryCode) { + if (!userId) { + return + } if (isAnalyticsDisabled() || isSmokeTestUser(userId)) { return } @@ -61,6 +70,9 @@ function updateEditingSession(userId, projectId, countryCode) { } function setUserProperty(userId, propertyName, propertyValue) { + if (!userId) { + return + } if (isAnalyticsDisabled() || isSmokeTestUser(userId)) { return }