From a1e16c967647538e01d37eb708990876222339f1 Mon Sep 17 00:00:00 2001 From: Jessica Lawshe Date: Wed, 13 Mar 2019 11:38:06 -0500 Subject: [PATCH] Merge pull request #1600 from sharelatex/as-rttc-text-markers Switch delete track change markers to use bookmark system to improve performance GitOrigin-RevId: 865003ba30728f7104ad4c1b9e114998aa7d66a0 --- .../aceEditor/track-changes/TrackChangesManager.js | 5 ----- services/web/public/stylesheets/app/editor/review-panel.less | 4 ++-- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/services/web/public/src/ide/editor/directives/aceEditor/track-changes/TrackChangesManager.js b/services/web/public/src/ide/editor/directives/aceEditor/track-changes/TrackChangesManager.js index e5b47a577f..4806ad32f6 100644 --- a/services/web/public/src/ide/editor/directives/aceEditor/track-changes/TrackChangesManager.js +++ b/services/web/public/src/ide/editor/directives/aceEditor/track-changes/TrackChangesManager.js @@ -20,7 +20,6 @@ define([ this.onPaste = this.onPaste.bind(this) this.onResize = this.onResize.bind(this) this.tearDown = this.tearDown.bind(this) - this.onDisplayUpdate = this.onDisplayUpdate.bind(this) this.$scope = $scope this.editor = editor @@ -426,10 +425,6 @@ define([ }) } - onDisplayUpdate() { - requestAnimationFrame(this.adapter.changeMarkerPositions) - } - onCut() { this._resetCutState() const selection = this.editor.getSelectionRange() diff --git a/services/web/public/stylesheets/app/editor/review-panel.less b/services/web/public/stylesheets/app/editor/review-panel.less index 6537addc33..c35d2567cd 100644 --- a/services/web/public/stylesheets/app/editor/review-panel.less +++ b/services/web/public/stylesheets/app/editor/review-panel.less @@ -937,10 +937,10 @@ color: black; } - .track-changes-deleted-marker-callout { + .track-changes-deleted-marker { + border-left: 2px dotted #c5060b; // Commented out styles for callout to be reimplemented later // border-bottom: 1px dashed #c5060b; - border-left: 2px dotted #c5060b; // width: 100%; }