Merge pull request #18828 from overleaf/ac-node-20

Upgrade Node from `18.20.2` to `20.17.0`

GitOrigin-RevId: 0ba9b0921fc246a97d3da0aad7d48635c0e24ae8
This commit is contained in:
Andrew Rumble
2024-10-29 10:49:30 +00:00
committed by Copybot
parent 74bee7e30b
commit a480df8a89
87 changed files with 113 additions and 109 deletions

View File

@@ -1 +1 @@
18.20.2
20.18.0

View File

@@ -2,7 +2,7 @@
# Instead run bin/update_build_scripts from
# https://github.com/overleaf/internal/
FROM node:18.20.2 AS base
FROM node:20.18.0 AS base
WORKDIR /overleaf/services/document-updater

View File

@@ -32,12 +32,12 @@ HERE=$(shell pwd)
MONOREPO=$(shell cd ../../ && pwd)
# Run the linting commands in the scope of the monorepo.
# Eslint and prettier (plus some configs) are on the root.
RUN_LINTING = docker run --rm -v $(MONOREPO):$(MONOREPO) -w $(HERE) node:18.20.2 npm run --silent
RUN_LINTING = docker run --rm -v $(MONOREPO):$(MONOREPO) -w $(HERE) node:20.18.0 npm run --silent
RUN_LINTING_CI = docker run --rm --volume $(MONOREPO)/.editorconfig:/overleaf/.editorconfig --volume $(MONOREPO)/.eslintignore:/overleaf/.eslintignore --volume $(MONOREPO)/.eslintrc:/overleaf/.eslintrc --volume $(MONOREPO)/.prettierignore:/overleaf/.prettierignore --volume $(MONOREPO)/.prettierrc:/overleaf/.prettierrc --volume $(MONOREPO)/tsconfig.backend.json:/overleaf/tsconfig.backend.json ci/$(PROJECT_NAME):$(BRANCH_NAME)-$(BUILD_NUMBER) npm run --silent
# Same but from the top of the monorepo
RUN_LINTING_MONOREPO = docker run --rm -v $(MONOREPO):$(MONOREPO) -w $(MONOREPO) node:18.20.2 npm run --silent
RUN_LINTING_MONOREPO = docker run --rm -v $(MONOREPO):$(MONOREPO) -w $(MONOREPO) node:20.18.0 npm run --silent
format:
$(RUN_LINTING) format

View File

@@ -4,6 +4,6 @@ document-updater
--env-add=
--env-pass-through=
--esmock-loader=False
--node-version=18.20.2
--node-version=20.18.0
--public-repo=True
--script-version=4.5.0

View File

@@ -6,7 +6,7 @@ version: "2.3"
services:
test_unit:
image: node:18.20.2
image: node:20.18.0
volumes:
- .:/overleaf/services/document-updater
- ../../node_modules:/overleaf/node_modules
@@ -20,7 +20,7 @@ services:
user: node
test_acceptance:
image: node:18.20.2
image: node:20.18.0
volumes:
- .:/overleaf/services/document-updater
- ../../node_modules:/overleaf/node_modules