From aa40894fb080e9ab22876daeade1b224ac5f53f1 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Syn=C3=A9sio=20Neto?= <synesio.neto@outlook.com>
Date: Tue, 2 Jun 2026 23:34:46 -0300
Subject: [PATCH] Fix a greyed out create file button after the Zotero
 Integration was merged.

---
 .../js/components/zotero-create-file.tsx      | 45 ++++++++++++++-----
 1 file changed, 34 insertions(+), 11 deletions(-)

diff --git a/services/web/modules/zotero/frontend/js/components/zotero-create-file.tsx b/services/web/modules/zotero/frontend/js/components/zotero-create-file.tsx
index cae993df60..ba311f1de3 100644
--- a/services/web/modules/zotero/frontend/js/components/zotero-create-file.tsx
+++ b/services/web/modules/zotero/frontend/js/components/zotero-create-file.tsx
@@ -35,10 +35,19 @@ export function CreateFileMode() {
 }
 
 export function CreateFilePane() {
+  const { newFileCreateMode } = useFileTreeActionable()
+
+  if (newFileCreateMode !== 'zotero') {
+    return null
+  }
+
+  return <ZoteroCreateFilePane />
+}
+
+function ZoteroCreateFilePane() {
   const { t } = useTranslation()
   const { setValid } = useFileTreeCreateForm()
-  const { newFileCreateMode, finishCreatingLinkedFile, error, inFlight } =
-    useFileTreeActionable()
+  const { finishCreatingLinkedFile, error, inFlight } = useFileTreeActionable()
 
   const [groups, setGroups] = useState<ZoteroGroup[]>([])
   const [selectedGroupId, setSelectedGroupId] = useState<string>('')
@@ -46,33 +55,45 @@ export function CreateFilePane() {
   const [loadingGroups, setLoadingGroups] = useState(true)
   const [groupsError, setGroupsError] = useState('')
 
-  // form validation
   useEffect(() => {
     setValid(!!name && !loadingGroups)
   }, [setValid, name, loadingGroups])
 
-  // load groups when the mode is active
   useEffect(() => {
-    if (newFileCreateMode !== 'zotero') return
+    let cancelled = false
 
     setLoadingGroups(true)
     setGroupsError('')
+
     getJSON('/zotero/groups')
       .then((data: { groups: ZoteroGroup[] }) => {
+        if (cancelled) return
+
         setGroups(data.groups || [])
         setLoadingGroups(false)
       })
       .catch(() => {
+        if (cancelled) return
+
         setGroupsError(t('zotero_groups_loading_error'))
         setLoadingGroups(false)
       })
-  }, [newFileCreateMode, t])
+
+    return () => {
+      cancelled = true
+    }
+  }, [t])
 
   const handleSubmit: FormEventHandler = useCallback(
     event => {
       event.preventDefault()
 
+      if (!name || loadingGroups || inFlight) {
+        return
+      }
+
       const data: Record<string, string> = {}
+
       if (selectedGroupId) {
         data.zoteroGroupId = selectedGroupId
       }
@@ -83,13 +104,15 @@ export function CreateFilePane() {
         data,
       })
     },
-    [name, selectedGroupId, finishCreatingLinkedFile]
+    [
+      name,
+      loadingGroups,
+      inFlight,
+      selectedGroupId,
+      finishCreatingLinkedFile,
+    ]
   )
 
-  if (newFileCreateMode !== 'zotero') {
-    return null
-  }
-
   return (
     <form
       className="form-controls"