From ac526b83c8d1223216f969dd5b38c75869d79ceb Mon Sep 17 00:00:00 2001
From: Jessica Lawshe <5312836+lawshe@users.noreply.github.com>
Date: Wed, 15 Jan 2025 09:54:04 -0600
Subject: [PATCH] Merge pull request #22824 from overleaf/jel-saml-tests

[web] SAML test helper update

GitOrigin-RevId: 6a721901b0026286e0ef28ed9168c8b97cd4a200
---
 services/web/test/acceptance/src/helpers/SAMLHelper.mjs | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/services/web/test/acceptance/src/helpers/SAMLHelper.mjs b/services/web/test/acceptance/src/helpers/SAMLHelper.mjs
index 76265e1774..6732454c1e 100644
--- a/services/web/test/acceptance/src/helpers/SAMLHelper.mjs
+++ b/services/web/test/acceptance/src/helpers/SAMLHelper.mjs
@@ -57,7 +57,9 @@ function createMockSamlAssertion(samlData = {}, opts = {}) {
   const { signedAssertion = true } = opts
 
   const userIdAttributeName = samlData.userIdAttribute || 'uniqueId'
-  const userIdAttribute = `<saml:AttributeStatement>
+  const userIdAttribute =
+    uniqueId &&
+    `<saml:AttributeStatement>
     <saml:Attribute Name="${userIdAttributeName}" NameFormat="urn:oasis:names:tc:SAML:2.0:attrname-format:unspecified">
       <saml:AttributeValue xmlns:xs="http://www.w3.org/2001/XMLSchema" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:type="xs:string">${uniqueId}</saml:AttributeValue>
     </saml:Attribute>