From ad3eb0bfcca8099aae7bb1855ef781b383cde86f Mon Sep 17 00:00:00 2001 From: Alexandre Bourdin Date: Mon, 13 Jun 2022 15:42:51 +0200 Subject: [PATCH] Merge pull request #8389 from overleaf/ab-fix-analytics-enabled-flag Skip persisting assignment when analyticsEnabled is turned off GitOrigin-RevId: e22b2cc29a5741ad90743ebaf5eb2c91cca0a2f5 --- .../app/src/Features/SplitTests/SplitTestHandler.js | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/services/web/app/src/Features/SplitTests/SplitTestHandler.js b/services/web/app/src/Features/SplitTests/SplitTestHandler.js index d5a362b185..758a441c0e 100644 --- a/services/web/app/src/Features/SplitTests/SplitTestHandler.js +++ b/services/web/app/src/Features/SplitTests/SplitTestHandler.js @@ -192,10 +192,12 @@ async function _getAssignment( phase, versionNumber, } - if (sync === true) { - await _updateVariantAssignment(assignmentConfig) - } else { - _updateVariantAssignment(assignmentConfig) + if (currentVersion.analyticsEnabled) { + if (sync === true) { + await _updateVariantAssignment(assignmentConfig) + } else { + _updateVariantAssignment(assignmentConfig) + } } return _makeAssignment(splitTest, selectedVariantName, currentVersion) }