From ae5a08e68086aec4fbde66090895596dd42dda68 Mon Sep 17 00:00:00 2001 From: M Fahru Date: Wed, 28 Dec 2022 10:33:12 -0700 Subject: [PATCH] Add 'setting-changed' tracking when user changes user-wide settings GitOrigin-RevId: 04ed66dcdff7fa04e783fe4028505d981a39b37b --- .../editor-left-menu/hooks/use-save-user-settings.tsx | 6 ++++++ .../editor-left-menu/hooks/use-set-spell-check-language.tsx | 6 ++++++ 2 files changed, 12 insertions(+) diff --git a/services/web/frontend/js/features/editor-left-menu/hooks/use-save-user-settings.tsx b/services/web/frontend/js/features/editor-left-menu/hooks/use-save-user-settings.tsx index 47038c08dc..e9d28eb86f 100644 --- a/services/web/frontend/js/features/editor-left-menu/hooks/use-save-user-settings.tsx +++ b/services/web/frontend/js/features/editor-left-menu/hooks/use-save-user-settings.tsx @@ -1,4 +1,5 @@ import useScopeValue from '../../../shared/hooks/use-scope-value' +import { sendMB } from '../../../infrastructure/event-tracking' import { saveUserSettings } from '../utils/api' import type { UserSettingsScope } from '../utils/api' @@ -12,6 +13,11 @@ export default function useSaveUserSettings() { ) => { const currentSetting = userSettingsScope[key] + sendMB('setting-changed', { + changedSetting: key, + changedSettingVal: newSetting, + }) + if (currentSetting !== newSetting) { setUserSettingsScope({ ...userSettingsScope, [key]: newSetting }) saveUserSettings({ [key]: newSetting }) diff --git a/services/web/frontend/js/features/editor-left-menu/hooks/use-set-spell-check-language.tsx b/services/web/frontend/js/features/editor-left-menu/hooks/use-set-spell-check-language.tsx index 9994fd9dd9..30ad4d8a15 100644 --- a/services/web/frontend/js/features/editor-left-menu/hooks/use-set-spell-check-language.tsx +++ b/services/web/frontend/js/features/editor-left-menu/hooks/use-set-spell-check-language.tsx @@ -1,4 +1,5 @@ import { useCallback } from 'react' +import { sendMB } from '../../../infrastructure/event-tracking' import { useProjectContext } from '../../../shared/context/project-context' import useScopeValue from '../../../shared/hooks/use-scope-value' import { saveProjectSettings, saveUserSettings } from '../utils/api' @@ -11,6 +12,11 @@ export default function useSetSpellCheckLanguage() { const setSpellCheckLanguage = useCallback( (spellCheckLanguage: string) => { if (spellCheckLanguageScope) { + sendMB('setting-changed', { + changedSetting: 'spellCheckLanguage', + changedSettingVal: spellCheckLanguage, + }) + setSpellCheckLanguageScope(spellCheckLanguage) // save to both project setting and user setting