From 15d3e5eb6e79bbf813350d8b9aefc74a4e20f204 Mon Sep 17 00:00:00 2001 From: Alasdair Smith Date: Wed, 8 Nov 2017 10:31:41 +0000 Subject: [PATCH 1/4] Fix triggering autocompile in rollout --- .../web/public/coffee/ide/pdf/controllers/PdfController.coffee | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/services/web/public/coffee/ide/pdf/controllers/PdfController.coffee b/services/web/public/coffee/ide/pdf/controllers/PdfController.coffee index 4846837856..e2bb51a0fd 100644 --- a/services/web/public/coffee/ide/pdf/controllers/PdfController.coffee +++ b/services/web/public/coffee/ide/pdf/controllers/PdfController.coffee @@ -109,7 +109,7 @@ define [ toggleAutoCompile(newValue) event_tracking.sendMB "autocompile-setting-changed", { value: newValue } - if (window.user?.betaProgram or window.showAutoCompileOnboarding) and $scope.autocompile_enabled + if (window.user?.betaProgram or window.autoCompileEnabled) and $scope.autocompile_enabled toggleAutoCompile(true) # abort compile if syntax checks fail From 76e3f0ab9ff8cc9c0f52808745d2af067ff964d0 Mon Sep 17 00:00:00 2001 From: Alasdair Smith Date: Wed, 8 Nov 2017 11:01:20 +0000 Subject: [PATCH 2/4] Reduce rollout to 5% --- .../web/app/coffee/Features/Project/ProjectController.coffee | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/services/web/app/coffee/Features/Project/ProjectController.coffee b/services/web/app/coffee/Features/Project/ProjectController.coffee index 944198e735..b7282d77ef 100644 --- a/services/web/app/coffee/Features/Project/ProjectController.coffee +++ b/services/web/app/coffee/Features/Project/ProjectController.coffee @@ -259,7 +259,7 @@ module.exports = ProjectController = timestamp = parseInt(user_id.toString().substring(0, 8), 16) counter = parseInt(user_id.toString().substring(18, 24), 16) - rolloutPercentage = 60 # Percentage of users to roll out to + rolloutPercentage = 5 # Percentage of users to roll out to if counter % 100 > rolloutPercentage # Don't show if user is not part of roll out return cb(null, { enabled: false, showOnboarding: false }) From 8174a849a1d7243f7c3f53f05f11bb3dcddd54df Mon Sep 17 00:00:00 2001 From: Alasdair Smith Date: Wed, 8 Nov 2017 11:01:36 +0000 Subject: [PATCH 3/4] Reset to new analytics key --- .../web/app/coffee/Features/Project/ProjectController.coffee | 2 +- .../public/coffee/ide/AutoCompileOnboardingController.coffee | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/services/web/app/coffee/Features/Project/ProjectController.coffee b/services/web/app/coffee/Features/Project/ProjectController.coffee index b7282d77ef..3d7588e28a 100644 --- a/services/web/app/coffee/Features/Project/ProjectController.coffee +++ b/services/web/app/coffee/Features/Project/ProjectController.coffee @@ -268,7 +268,7 @@ module.exports = ProjectController = # Don't show for users who registered after it was released return cb(null, { enabled: true, showOnboarding: false }) timeout = setTimeout cb, 500 - AnalyticsManager.getLastOccurance user_id, "shown-autocompile-onboarding", (error, event) -> + AnalyticsManager.getLastOccurance user_id, "shown-autocompile-onboarding-2", (error, event) -> clearTimeout timeout if error? return cb(null, { enabled: true, showOnboarding: false }) diff --git a/services/web/public/coffee/ide/AutoCompileOnboardingController.coffee b/services/web/public/coffee/ide/AutoCompileOnboardingController.coffee index a57575fb94..30a629f1fe 100644 --- a/services/web/public/coffee/ide/AutoCompileOnboardingController.coffee +++ b/services/web/public/coffee/ide/AutoCompileOnboardingController.coffee @@ -23,4 +23,4 @@ define [ $scope.dismiss = () -> $scope.onboarding.autoCompile = 'dismissed' - event_tracking.sendMB "shown-autocompile-onboarding" + event_tracking.sendMB "shown-autocompile-onboarding-2" From 80231b0c1fea260fcd0ef8674ccf41c91b24739f Mon Sep 17 00:00:00 2001 From: Alasdair Smith Date: Wed, 8 Nov 2017 12:42:47 +0000 Subject: [PATCH 4/4] 1% rollout --- .../web/app/coffee/Features/Project/ProjectController.coffee | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/services/web/app/coffee/Features/Project/ProjectController.coffee b/services/web/app/coffee/Features/Project/ProjectController.coffee index 3d7588e28a..d710062fbc 100644 --- a/services/web/app/coffee/Features/Project/ProjectController.coffee +++ b/services/web/app/coffee/Features/Project/ProjectController.coffee @@ -259,7 +259,7 @@ module.exports = ProjectController = timestamp = parseInt(user_id.toString().substring(0, 8), 16) counter = parseInt(user_id.toString().substring(18, 24), 16) - rolloutPercentage = 5 # Percentage of users to roll out to + rolloutPercentage = 1 # Percentage of users to roll out to if counter % 100 > rolloutPercentage # Don't show if user is not part of roll out return cb(null, { enabled: false, showOnboarding: false })