From af82f259442b410dc8bb39e2afba563a7b3542bb Mon Sep 17 00:00:00 2001 From: Jimmy Domagala-Tang Date: Wed, 25 Feb 2026 09:57:27 -0500 Subject: [PATCH] feat: fixing conversions in metrics (#31610) GitOrigin-RevId: 76bae4b780c3b9a2c1de6c8d0bbf175634080804 --- .../Features/UserMembership/UserMembershipMiddleware.mjs | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/services/web/app/src/Features/UserMembership/UserMembershipMiddleware.mjs b/services/web/app/src/Features/UserMembership/UserMembershipMiddleware.mjs index 1e5af050a6..3eaefd9859 100644 --- a/services/web/app/src/Features/UserMembership/UserMembershipMiddleware.mjs +++ b/services/web/app/src/Features/UserMembership/UserMembershipMiddleware.mjs @@ -292,7 +292,14 @@ function requireGraphAccess(req, res, next) { // call next router with fixed params to pass it to the correct middleware chain const { graph } = req.params const entityRoute = entityName === 'splitTest' ? 'split-test' : entityName - req.url = `/graphs/${entityRoute}/${graph}/${req.query.resource_id}` + + // all other routes go through analytics, which map undefined graph type to index (to fetch all graphs) + // conversion still goes directly to v1, which can not handle an undefined graph param + if (!graph?.length && entityRoute === 'conversion') { + req.url = `/graphs/conversion/index/${req.query.resource_id}` + } else { + req.url = `/graphs/${entityRoute}/${graph}/${req.query.resource_id}` + } next('route') }