From b01b05e49bbf08443cf3dc1d303f49ec02c8fd67 Mon Sep 17 00:00:00 2001 From: Henry Oswald Date: Tue, 7 Oct 2014 11:14:02 +0100 Subject: [PATCH] server rejects project names over 150 chars --- .../app/coffee/Features/Project/ProjectController.coffee | 2 ++ .../UnitTests/coffee/Project/ProjectControllerTests.coffee | 7 +++++++ 2 files changed, 9 insertions(+) diff --git a/services/web/app/coffee/Features/Project/ProjectController.coffee b/services/web/app/coffee/Features/Project/ProjectController.coffee index 840ef53d79..dc6508be04 100644 --- a/services/web/app/coffee/Features/Project/ProjectController.coffee +++ b/services/web/app/coffee/Features/Project/ProjectController.coffee @@ -109,6 +109,8 @@ module.exports = ProjectController = renameProject: (req, res)-> project_id = req.params.Project_id newName = req.body.newProjectName + if newName.length > 150 + return res.send 400 editorController.renameProject project_id, newName, (err)-> if err? logger.err err:err, project_id:project_id, newName:newName, "problem renaming project" diff --git a/services/web/test/UnitTests/coffee/Project/ProjectControllerTests.coffee b/services/web/test/UnitTests/coffee/Project/ProjectControllerTests.coffee index 617aa3ba42..25ea9ec75e 100644 --- a/services/web/test/UnitTests/coffee/Project/ProjectControllerTests.coffee +++ b/services/web/test/UnitTests/coffee/Project/ProjectControllerTests.coffee @@ -252,6 +252,13 @@ describe "ProjectController", -> done() @ProjectController.renameProject @req, @res + it "should return an error if the name is over 150 chars", (done)-> + @req.body.newProjectName = "EDMUBEEBKBXUUUZERMNSXFFWIBHGSDAWGMRIQWJBXGWSBVWSIKLFPRBYSJEKMFHTRZBHVKJSRGKTBHMJRXPHORFHAKRNPZGGYIOTEDMUBEEBKBXUUUZERMNSXFFWIBHGSDAWGMRIQWJBXGWSBVWSIKLFPRBYSJEKMFHTRZBHVKJSRGKTBHMJRXPHORFHAKRNPZGGYIOT" + @res.send = (code)=> + code.should.equal 400 + done() + @ProjectController.renameProject @req, @res + describe "loadEditor", -> beforeEach -> @settings.editorIsOpen = true