From b03380c0b24e15acc0e151c0acf102ee2453efa7 Mon Sep 17 00:00:00 2001 From: Alexandre Bourdin Date: Tue, 4 Oct 2022 10:21:32 +0200 Subject: [PATCH] Merge pull request #9836 from overleaf/ab-fix-dash-null-user-error [web] Do not fail loading the project list when a deleted user is referenced as a project's lastUpdatedBy GitOrigin-RevId: cd2a7b7a6a03a1775fd436f7bc233a6f1a359bd4 --- .../Features/Project/ProjectListController.js | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/services/web/app/src/Features/Project/ProjectListController.js b/services/web/app/src/Features/Project/ProjectListController.js index bfa7ea7c08..52f2cfd2c0 100644 --- a/services/web/app/src/Features/Project/ProjectListController.js +++ b/services/web/app/src/Features/Project/ProjectListController.js @@ -477,20 +477,18 @@ async function _injectProjectUsers(projects) { const users = {} for (const userId of userIds) { - const { - email, - first_name: firstName, - last_name: lastName, - } = await UserGetter.promises.getUser(userId, { + const user = await UserGetter.promises.getUser(userId, { first_name: 1, last_name: 1, email: 1, }) - users[userId] = { - id: userId, - email, - firstName, - lastName, + if (user) { + users[userId] = { + id: userId, + email: user.email, + firstName: user.first_name, + lastName: user.last_name, + } } } for (const project of projects) {