Merge pull request #1924 from overleaf/ta-full-error

Don't Callback with String

GitOrigin-RevId: 82e3efb055ef197d95ff9c8a876bee0d6a0327a3
This commit is contained in:
Timothée Alby
2019-07-01 15:54:23 +02:00
committed by sharelatex
parent c86910a5ef
commit b1e8cb9cf0
13 changed files with 78 additions and 33 deletions

View File

@@ -159,11 +159,11 @@ module.exports = EditorHttpController = {
'editor',
user_id,
function(error, doc) {
if (error === 'project_has_to_many_files') {
if (error && error.message === 'project_has_to_many_files') {
return res
.status(400)
.json(req.i18n.translate('project_has_to_many_files'))
} else if (error != null) {
} else if (error) {
return next(error)
} else {
return res.json(doc)
@@ -185,15 +185,13 @@ module.exports = EditorHttpController = {
name,
'editor',
function(error, doc) {
if (error === 'project_has_to_many_files') {
if (error && error.message === 'project_has_to_many_files') {
return res
.status(400)
.json(req.i18n.translate('project_has_to_many_files'))
} else if (
(error != null ? error.message : undefined) === 'invalid element name'
) {
} else if (error && error.message === 'invalid element name') {
return res.status(400).json(req.i18n.translate('invalid_file_name'))
} else if (error != null) {
} else if (error) {
return next(error)
} else {
return res.json(doc)