agw/overleaf-cep
1
0
Fork 0
mirror of https://github.com/yu-i-i/overleaf-cep.git synced 2026-05-31 12:51:35 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1924 from overleaf/ta-full-error

Browse Source 
Don't Callback with String

GitOrigin-RevId: 82e3efb055ef197d95ff9c8a876bee0d6a0327a3
This commit is contained in:
Timothée Alby
2019-07-01 15:54:23 +02:00
committed by sharelatex
parent c86910a5ef
commit b1e8cb9cf0
13 changed files with 78 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
services/web/app/src/Features/Project/ProjectEntityUpdateHandler.js
View File

@@ -1130,7 +1130,7 @@ module.exports = ProjectEntityUpdateHandler = self = {
logger.log({ entity_id, entityType, project_id }, 'deleting project entity')
if (entityType == null) {
logger.warn({ err: 'No entityType set', project_id, entity_id })
return callback('No entityType set')
return callback(new Error('No entityType set'))
}
entityType = entityType.toLowerCase()
return ProjectEntityMongoUpdateHandler.deleteEntity(
@@ -1261,7 +1261,7 @@ module.exports = ProjectEntityUpdateHandler = self = {
)
if (entityType == null) {
logger.warn({ err: 'No entityType set', project_id, entity_id })
return callback('No entityType set')
return callback(new Error('No entityType set'))
}
entityType = entityType.toLowerCase()
return ProjectEntityMongoUpdateHandler.moveEntity(
@@ -1309,7 +1309,7 @@ module.exports = ProjectEntityUpdateHandler = self = {
logger.log({ entity_id, project_id }, `renaming ${entityType}`)
if (entityType == null) {
logger.warn({ err: 'No entityType set', project_id, entity_id })
return callback('No entityType set')
return callback(new Error('No entityType set'))
}
entityType = entityType.toLowerCase()